Issue Details (XML | Word | Printable)

Key: MDL-12879
Type: Bug Bug
Status: Closed Closed
Resolution: Cannot Reproduce
Priority: Minor Minor
Assignee: Dan Poltawski
Reporter: Steve Bond
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

RSS feeds block title corrupted when URL included

Created: 09/Jan/08 01:59 AM   Updated: 09/Jan/08 07:51 PM
Return to search
Component/s: Blocks, RSS
Affects Version/s: 1.8.3
Fix Version/s: None

File Attachments: None
Image Attachments:

1. rss_block.gif
(7 kB)
Issue Links:
Dependency
 

Participants: Dan Poltawski and Steve Bond
Security Level: None
Affected Branches: MOODLE_18_STABLE


 Description  « Hide
Since upgrading to 1.8.3, many of our RSS feed blocks now have corrupted titles. The problem did not occur in 1.8.2.

An example screenshot is attached. This is a simple link to 'The Economist' news feed, where the 'title' field has been left blank when configuring the block. Judging by the source code, Moodle is inserting the URL of The Economist website into places where it doesn't belong, such as in the ALT text, and in the arguments of the JavaScript function elementToggleHide().

The code on line 262 of blocks/moodleblock.class.php is a starting point for the problem. The problem seems to be that $this->title already contains the hyperlink by the time it is used to form the ALT tag etc.; but I'm not clear as to where $this->title is defined, or what would be the consequences of changing it.

Hopefully someone with better understanding of this class can help?

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Poltawski made changes - 09/Jan/08 06:46 AM
Field Original Value New Value
Assignee Martin Dougiamas [ dougiamas ] Dan Poltawski [ poltawski ]
Dan Poltawski made changes - 09/Jan/08 08:24 AM
Link This issue will be resolved by MDL-7493 [ MDL-7493 ]
Dan Poltawski made changes - 09/Jan/08 08:25 AM
Resolution Cannot Reproduce [ 5 ]
Status Open [ 1 ] Closed [ 6 ]