Moodle

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9, 2.0
• Fix Version/s: 1.9, 2.0
• Component/s: Tags
• Labels:

  None

I was looking code due to MDL-12897 when, in cache_correlated_tags(), this query:

$query = "SELECT tb.tagid , COUNT nr
FROM {$CFG->prefix}tag_instance ta
INNER JOIN {$CFG->prefix}tag_instance tb ON ta.itemid = tb.itemid
WHERE ta.tagid = {$tag_id}
GROUP BY tb.tagid
ORDER BY nr DESC";

seems to be missing one extra condition, in order to compare only same itemtype tags (or else we'll be counting unrelated items), so this join seems necessary:

INNER JOIN {$CFG->prefix}tag_instance tb ON ta.itemid = tb.itemid AND ta.itemtype = tb.itemtype

instead of the current one.

Ciao

• Assignee:

  Mathieu Petit-Clair

  Reporter:

  Eloy Lafuente (stronk7)

  Participants:

  Eloy Lafuente (stronk7), Mathieu Petit-Clair

• Created:

  10/Jan/08 4:56 AM

  Updated:

  17/Dec/10 1:04 PM

  Resolved:

  22/Feb/08 7:36 PM