Moodle

Random Short-Answer Matching does not display correctly in Item analysis report

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 2.0
  • Component/s: Quiz
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The Random Short-Answer Matching does not display correctly in Item analysis report due to some difference in the question data with the match question type from which this question type is an extension.
Also Random Short-Answer Matching quesiton is a virtual question type that only exists in the $states session parameter and report.php has to be corrected for this.
A solution has been found as shown in the attach files.
The diff files for HEAD are also attached

Attachments

  1. Text File
    analysis_report.php.patch
    11/Jan/08 11:22 PM
    0.8 kB
    Pierre Pichet
  2. Text File
    randomsamatch_questiontype.php.patch
    11/Jan/08 11:22 PM
    1 kB
    Pierre Pichet
  1. bugreport.jpg
    199 kB
    11/Jan/08 11:22 PM
  2. corrected.jpg
    184 kB
    11/Jan/08 11:22 PM

Issue Links

This issue will be resolved by:
MDL-14184 General Improvements to Quiz Reports Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Pierre Pichet added a comment - - edited

CVS on HEAD, will merged on other versions later.
A more flexible (plug-in) solution will be to add a new questiontype function is_virtual_questiontype () that returns a default value of false for normal question types.
I will wait until the work on item analysis report is completed.

Show
Pierre Pichet added a comment - - edited CVS on HEAD, will merged on other versions later. A more flexible (plug-in) solution will be to add a new questiontype function is_virtual_questiontype () that returns a default value of false for normal question types. I will wait until the work on item analysis report is completed.
Hide
Permalink
Martin Dougiamas added a comment -

Is this something that should be in 1.9?

Show
Martin Dougiamas added a comment - Is this something that should be in 1.9?
Hide
Permalink
Martin Dougiamas added a comment -

(Thanks Pierre

Also, please include MDL-12932 in the check-in messages so that the changes get attached to this bug automatically.

Show
Martin Dougiamas added a comment - (Thanks Pierre Also, please include MDL-12932 in the check-in messages so that the changes get attached to this bug automatically.
Hide
Permalink
Pierre Pichet added a comment -

I have found also that the quiz reviews incliding the item analysis does not display correctly when the questions used in a Random Short-Answer Matching question have been deleted.
I will put at least a significant error message in randomsamatch/questiontype->restore_session_and_responses(&$question, &$state) {

The real solution will be to do a better checking before deleting a question. This is a more general problem that have been reported elsewhere.

I will CVS to HEAD shortly and merged as a partial solution to at least 1.9.
I will search for other related bugs after solving this

Show
Pierre Pichet added a comment - I have found also that the quiz reviews incliding the item analysis does not display correctly when the questions used in a Random Short-Answer Matching question have been deleted. I will put at least a significant error message in randomsamatch/questiontype->restore_session_and_responses(&$question, &$state) { The real solution will be to do a better checking before deleting a question. This is a more general problem that have been reported elsewhere. I will CVS to HEAD shortly and merged as a partial solution to at least 1.9. I will search for other related bugs after solving this
Hide
Permalink
Jamie Pratt added a comment -

Fixed in news stats report in Moodle 2.0

Show
Jamie Pratt added a comment - Fixed in news stats report in Moodle 2.0

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.