Moodle

Messaging: Include search on user email field (possibly even username)

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.8
  • Fix Version/s: None
  • Component/s: Messages
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

In other areas where Moodle searches for users, the fullname and email fields are searched. I also think that the username field should be searched. To be consistent, I think that when searching for users within the messaging system, the email field should also be checked.

Attachments

  1. File
    MDL-12967_username.diff
    14/Jan/08 1:41 AM
    1 kB
    Anthony Borrow
  2. File
    MDL-12967.diff
    14/Jan/08 1:14 AM
    1 kB
    Anthony Borrow

Issue Links

This issue has a non-specific relationship to:
MDL-3982 Searching by username Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

The attached diff file is for Moodle 18STABLE and adds the search to include email.

Show
Anthony Borrow added a comment - The attached diff file is for Moodle 18STABLE and adds the search to include email.
Hide
Permalink
Anthony Borrow added a comment -

I've modified the file to respect the maildisplay settings as followed:

If one is searching from the front page, then it requires the maildisplay to be 1 and will not display users who only want their email displayed to those with whom they share a course. Searching from within a course will display when maildisplay is not 0 (i.e. the user has requested to hide their email from others). Even though the email address is not being displayed, doing this avoids fishing for a person's email address.

Peace - Anthony

Show
Anthony Borrow added a comment - I've modified the file to respect the maildisplay settings as followed: If one is searching from the front page, then it requires the maildisplay to be 1 and will not display users who only want their email displayed to those with whom they share a course. Searching from within a course will display when maildisplay is not 0 (i.e. the user has requested to hide their email from others). Even though the email address is not being displayed, doing this avoids fishing for a person's email address. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Here is the patch that respects the user's maildisplay settings. Peace - Anthony

Show
Anthony Borrow added a comment - Here is the patch that respects the user's maildisplay settings. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I went ahead and create a patch to include the searching of the username field as well. This is related to MDL-3982 which requests that the username field be included on searches for users.

Show
Anthony Borrow added a comment - I went ahead and create a patch to include the searching of the username field as well. This is related to MDL-3982 which requests that the username field be included on searches for users.
Hide
Permalink
Anthony Borrow added a comment -

MDL-3982 requests that the username field be searched when searching for users. MDL-12967 requests that the email (and possibly) the username field be included when searching for users via the messaging system (/message/lib.php's search_users function). Resolving both of these would allow for user's to be found by entering a name that is in either the firstname, lastname, username, or email fields.

Show
Anthony Borrow added a comment - MDL-3982 requests that the username field be searched when searching for users. MDL-12967 requests that the email (and possibly) the username field be included when searching for users via the messaging system (/message/lib.php's search_users function). Resolving both of these would allow for user's to be found by entering a name that is in either the firstname, lastname, username, or email fields.

People

Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.