Issue Details (XML | Word | Printable)

Key: MDL-1297
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Jon Papaioannou
Reporter: Paul Duff
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Calendar Day/Month Mismatch

Created: 01/May/04 06:49 AM   Updated: 24/Aug/06 09:33 AM
Component/s: Calendar
Affects Version/s: 1.5
Fix Version/s: None

Environment: All

Participants: Jon Papaioannou, Martin Dougiamas, Michael Blake and Paul Duff
Security Level: None
Affected Branches: MOODLE_15_STABLE


 Description  « Hide
Moodle.org calendar at 11:20pm April 30th 2004 displays April day sequence but says May 2004 in header.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 01/May/05 07:04 AM
From Paul Duff (paulduff at wiltscoll.ac.uk) Saturday, 1 May 2004, 07:09 AM:

Displayed correctly after 12:00 midnight

From Jon Papaioannou (pj at moodle.org) Saturday, 1 May 2004, 08:07 AM:

I think I know what happened here, must be something I checked into CVS at about April 30, 9am GMT.

Martin, have you updated moodle.org since then or is my guess wrong?

From Martin Dougiamas (martin at moodle.com) Saturday, 1 May 2004, 11:46 AM:

Yep, I updated moodle.org after that I think.

So we can close this?

From Paul Duff (paulduff at wiltscoll.ac.uk) Saturday, 1 May 2004, 03:30 PM:

I'll try to check again on May 31st.

From Jon Papaioannou (pj at moodle.org) Monday, 3 May 2004, 11:31 PM:

I just now committed some changes which I think fix this problem. Otherwise, we 'll learn on May 31.

I 'm not sure if this must be left open, considering the above.

From Paul Duff (paulduff at wiltscoll.ac.uk) Tuesday, 4 May 2004, 05:32 AM:

I noticed the problem on the moodle.org site. Since the calendar is no longer there, I'll have to leave it to you to check at the end of the month.

Close call if you wish.

From Jon Papaioannou (pj at moodle.org) Saturday, 8 May 2004, 09:50 PM:

I have a hunch this was caused by the same glitch that caused MDL-1334. Since that one is fixed with 100% certainty, I 'm closing this one too. Reopen as necessary in the future if I 'm wrong.

From Paul Duff (paulduff at wiltscoll.ac.uk) Tuesday, 1 June 2004, 07:11 AM:

Checked again - see Calendar2.jpg. Note the time 23:11 - it is 31st May here in UK (DST), but the month in the calendar title has aleady advanced.

From Paul Duff (paulduff at wiltscoll.ac.uk) Tuesday, 1 June 2004, 07:13 AM:

... per last entry - the month title has advanced to June, but the day number block refers to May.

From Jon Papaioannou (pj at moodle.org) Tuesday, 1 June 2004, 07:19 PM:

Argh!!!! It seems to be caused by DST, and also these facts:

1. I don't know if PHP correctly detects DST, for example in one server I tried it on it doesn't.

2. Even if it did, that would be according to the server it runs on, which is in Australia.

3. Every country has different DST conventions, and sometimes even they don't follow them to the letter (take a look at http://webexhibits.org/daylightsaving/g.html)

To sum it up, fixing this problem would probably require manual detection of the user's DST status based upon the country field of the user profile. Kindly excuse me for intending to lower the priority of this nightmare and put it in the later list... :-/

From Paul Duff (paulduff at wiltscoll.ac.uk) Tuesday, 1 June 2004, 07:32 PM:

No problem here - just answering the earlier calls to test calendar, and re-testing as promised.

In the end, it's pretty trivial really since it only looks screwy for an hour!!

From Jon Papaioannou (pj at moodle.org) Saturday, 19 February 2005, 01:12 AM:

The latest 1.5 development versions support DST and thus should have solved this problem. Not enough testing done yet though, so I 'm not closing this.

From Jon Papaioannou (pj at moodle.org) Sunday, 1 May 2005, 07:04 AM:

One year later, complete timezone support fixes this for good.

Yay!


Michael Blake added a comment - 24/Aug/06 09:24 AM
Temporary transition to reassign bug to "pj".

Michael Blake added a comment - 24/Aug/06 09:33 AM
Re-closing bugs after re-assigning to "pj".