Moodle

Moodle groups interface should display the role of members and potential members

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 1.9, 2.0
  • Component/s: Groups
  • Labels:
    None
  • Database:
    Any
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

The groups interface used to distinguish between teachers and students. This has been removed in the transfer to the role system. All users are now displayed the same, which makes it less usable. Our administrators have requested that we put this feature back so I have.

My implementation of the feature works as follows:

  • Users are categorised by course role (i.e. their role directly on the course). Each role displays, in role sortorder, as an optgroup followed by the people in it.
  • Users can also have 'no role' on the course (if they have a role at a higher level) or 'multiple roles' (if they have two or more roles on the course). These are shown under those headings. The expectation is that normal usage would see few cases of people in these categories, or that it would be clear which they correspond to (i.e. somebody with multiple roles is most probably the group leader).
  • The lists displayed (members, potential members) are both intended to contain identical lists of users to before these changes - just in different order and with role headings.
  • I have implemented this display in three list boxes: the list of members on the first groups screen, and both the 'members' and 'potential members' boxes on the add/remove users screen. I have implemented it when AJAX is on (which only seems to affect the first case) as well as off. I did this patch against Moodle HEAD, although I am happy to port to 1.9 if it is desired there.
  • Those looking at the patch will see a few other changes; I fixed a few minor wording things in the javascript. That's it though (I hope).
  • The 'business logic' is in several new functions in group/lib.php. (There are no changes to any behaviour or database aspects of any other part of the system, this is strictly group UI only.)

Is this useful? If so, can I get the go ahead to commit it?

I have attached 2 screenshots and the patch.

  1. groupuiroles.patch
    17/Jan/08 8:25 PM
    21 kB
    Sam Marshall
  2. groupuiroles.patch
    15/Jan/08 1:32 AM
    23 kB
    Sam Marshall
  1. CF101- Groups.png
    13 kB
    15/Jan/08 1:32 AM
  2. CF101- Groups overview.png
    14 kB
    15/Jan/08 1:32 AM

Issue Links

Activity

Hide
Martin Dougiamas added a comment -

if users assigned roles at higher levels (eg category) show up as those roles (instead of "no roles"), but we keep the multiple roles, then I think this can go into 1.9 as well as head. +5

Show
Martin Dougiamas added a comment - if users assigned roles at higher levels (eg category) show up as those roles (instead of "no roles"), but we keep the multiple roles, then I think this can go into 1.9 as well as head. +5
Hide
Sam Marshall added a comment -

Here is a revised patch. This patch has been reviewed by tim, tidied up a bit, modified to work as Martin asked (i.e. it shows roles from all levels, so if you are Student at category level, that works as expected) and tested against our real data.

I am going to commit this now but thought I'd post the patch again (yeah, maybe not necessary since the tracker makes it automatically, but because there was an older patch, just to make clear that it has been revised).

Show
Sam Marshall added a comment - Here is a revised patch. This patch has been reviewed by tim, tidied up a bit, modified to work as Martin asked (i.e. it shows roles from all levels, so if you are Student at category level, that works as expected) and tested against our real data. I am going to commit this now but thought I'd post the patch again (yeah, maybe not necessary since the tracker makes it automatically, but because there was an older patch, just to make clear that it has been revised).
Hide
Sam Marshall added a comment -

Committed and tagged as merged. Affected files:

group/
clientlib.php
index.php
lib.php
members.php

lang/en_utf8/
role.php

This patch also going on to the OU live system, probably on Monday, so it should get some real-life testing.

Show
Sam Marshall added a comment - Committed and tagged as merged. Affected files: group/ clientlib.php index.php lib.php members.php lang/en_utf8/ role.php This patch also going on to the OU live system, probably on Monday, so it should get some real-life testing.
Hide
Martin Dougiamas added a comment -
Show
Martin Dougiamas added a comment - See MDL-13045
Hide
Nicolas Martignoni added a comment -

Re-closing

Show
Nicolas Martignoni added a comment - Re-closing

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: