Moodle

Error toggling Blocks editing on

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.4
  • Fix Version/s: 1.9.4
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Moodle Front Page
Site Administration block
Select: Front Page -> Front Page roles
In the page you get (admin/roles/assign.php?contextid=58 on my site) push the "Blocks editing on" button
What you get is: "A required parameter (contextid) was missing"

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniele Cordella added a comment -

it is the same in: User -> Permissions -> Assign system roles

If you do the same when you are in: User -> Accounts -> Add a new user blocks columns and "turn editing off" button disappear!!!

Show
Daniele Cordella added a comment - it is the same in: User -> Permissions -> Assign system roles If you do the same when you are in: User -> Accounts -> Add a new user blocks columns and "turn editing off" button disappear!!!
Hide
Permalink
Mark Ross added a comment -

I've seen this bug in 1.9 + (Build: 20080320) as well.

Show
Mark Ross added a comment - I've seen this bug in 1.9 + (Build: 20080320) as well.
Hide
Permalink
Helen Foster added a comment -

Daniele, thanks for reporting this issue.

Tim, thanks for fixing the problem when you toggle the blocks editing on button in front page roles and assign system roles.

However, the following problem, as mentioned by Daniele, still exists:

If you do the same when you are in: User -> Accounts -> Add a new user blocks columns and "turn editing off" button disappear!!!

Show
Helen Foster added a comment - Daniele, thanks for reporting this issue. Tim, thanks for fixing the problem when you toggle the blocks editing on button in front page roles and assign system roles. However, the following problem, as mentioned by Daniele, still exists: If you do the same when you are in: User -> Accounts -> Add a new user blocks columns and "turn editing off" button disappear!!!
Hide
Permalink
Tim Hunt added a comment -

I was sure I had fixed this. Oh well, I'll look when I get back from holiday.

Show
Tim Hunt added a comment - I was sure I had fixed this. Oh well, I'll look when I get back from holiday.
Hide
Permalink
Tim Hunt added a comment -

Actually, I knew I had not fixed this.

There are about 80 'admin_external_pages'* that may be linked to from the admin tree, and I never claimed to have fixed them all.

What I have done is:

1. Introduce a mechanism so it is possible to fix these problems quite easily.
2. Review and fix the ones in areas of the code I feel responsible for (primarily roles and course category editing).

And I have now fixed the user editing page.

So, in future, if you find any more problems like this, it is probably better to file specific new bug reports, rather than re-opening this general one.

  • Actually, there are 85 occurrences of 'admin_externalpage_print_header' in the code, and I think I have reviewed about 25 of them.
Show
Tim Hunt added a comment - Actually, I knew I had not fixed this. There are about 80 'admin_external_pages'* that may be linked to from the admin tree, and I never claimed to have fixed them all. What I have done is: 1. Introduce a mechanism so it is possible to fix these problems quite easily. 2. Review and fix the ones in areas of the code I feel responsible for (primarily roles and course category editing). And I have now fixed the user editing page. So, in future, if you find any more problems like this, it is probably better to file specific new bug reports, rather than re-opening this general one.
  • Actually, there are 85 occurrences of 'admin_externalpage_print_header' in the code, and I think I have reviewed about 25 of them.
Hide
Permalink
Helen Foster added a comment -

Tim, thanks for your additional fixes and improvements. Toggling blocks editing works fine on the add a new user page now.

Show
Helen Foster added a comment - Tim, thanks for your additional fixes and improvements. Toggling blocks editing works fine on the add a new user page now.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.