Issue Details (XML | Word | Printable)

Key: MDL-13104
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Tim Hunt
Reporter: Daniele Cordella
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Error toggling Blocks editing on

Created: 23/Jan/08 08:09 PM   Updated: 06/Jan/09 10:21 PM
Return to search
Component/s: Administration
Affects Version/s: 1.8.4
Fix Version/s: 1.9.4

Participants: Daniele Cordella, Helen Foster, Mark Ross and Tim Hunt
Security Level: None
QA Assignee: Helen Foster
Resolved date: 22/Dec/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Moodle Front Page
Site Administration block
Select: Front Page -> Front Page roles
In the page you get (admin/roles/assign.php?contextid=58 on my site) push the "Blocks editing on" button
What you get is: "A required parameter (contextid) was missing"

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Daniele Cordella added a comment - 23/Jan/08 08:17 PM
it is the same in: User -> Permissions -> Assign system roles

If you do the same when you are in: User -> Accounts -> Add a new user blocks columns and "turn editing off" button disappear!!!


Mark Ross added a comment - 21/Mar/08 03:44 AM
I've seen this bug in 1.9 + (Build: 20080320) as well.

Helen Foster added a comment - 17/Dec/08 08:21 AM
Daniele, thanks for reporting this issue.

Tim, thanks for fixing the problem when you toggle the blocks editing on button in front page roles and assign system roles.

However, the following problem, as mentioned by Daniele, still exists:

If you do the same when you are in: User -> Accounts -> Add a new user blocks columns and "turn editing off" button disappear!!!


Tim Hunt added a comment - 17/Dec/08 07:44 PM
I was sure I had fixed this. Oh well, I'll look when I get back from holiday.

Tim Hunt added a comment - 22/Dec/08 12:28 PM
Actually, I knew I had not fixed this.

There are about 80 'admin_external_pages'* that may be linked to from the admin tree, and I never claimed to have fixed them all.

What I have done is:

1. Introduce a mechanism so it is possible to fix these problems quite easily.
2. Review and fix the ones in areas of the code I feel responsible for (primarily roles and course category editing).

And I have now fixed the user editing page.

So, in future, if you find any more problems like this, it is probably better to file specific new bug reports, rather than re-opening this general one.

  • Actually, there are 85 occurrences of 'admin_externalpage_print_header' in the code, and I think I have reviewed about 25 of them.

Helen Foster added a comment - 06/Jan/09 10:21 PM
Tim, thanks for your additional fixes and improvements. Toggling blocks editing works fine on the add a new user page now.