Moodle

Backup doesn't respect the users=none setting at all

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.9, 2.0
  • Fix Version/s: 1.8.5, 1.9, 2.0
  • Component/s: Backup
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

I was playing with MDL-10721 when I've detected that the backup_users = none setting isn't respected by a lot of parts of backup.

Correctly, the <USERS> section is missing in the backup file, but:

  • User grades are exported.
  • Activities user info are exported (responses, modules...)
  • Header info of activities show USERINFO = yes, while it should be no!

This causes backup to export a lot of unneeded data, spending a lot of extra time and making difficult to compare scheduled backups and manual backups, so I'll try this first.

Ciao

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Now the backup_users = none is respected and populated to the backup configuration of each module. So we are avoiding the output of all the user-related information from activities, as desired!

Anyway, some things must still be checked:

  • Grades
  • Roles assignments

Tomorrow more. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Now the backup_users = none is respected and populated to the backup configuration of each module. So we are avoiding the output of all the user-related information from activities, as desired! Anyway, some things must still be checked:
  • Grades
  • Roles assignments
Tomorrow more. Ciao
Hide
Eloy Lafuente (stronk7) added a comment -

Now roles assignments are only exported for target users.

Going to check the grades now.

Show
Eloy Lafuente (stronk7) added a comment - Now roles assignments are only exported for target users. Going to check the grades now.
Hide
Eloy Lafuente (stronk7) added a comment -

Done for grade_grades and grade_grades_history

It seems that there are some remaining places (like events or scales). But looking restore, they have worked being reassigned to admin if original user isn't there on restore. I'll keep that behaviour for now.

Closing this. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Done for grade_grades and grade_grades_history It seems that there are some remaining places (like events or scales). But looking restore, they have worked being reassigned to admin if original user isn't there on restore. I'll keep that behaviour for now. Closing this. Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: