Issue Details (XML | Word | Printable)

Key: MDL-13142
Type: Sub-task Sub-task
Status: In Progress In Progress
Priority: Minor Minor
Assignee: Jordi Piguillem Poch
Reporter: Martin Dougiamas
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-20806

add_groups

Created: 24/Jan/08 03:26 PM   Updated: 11/Nov/09 11:13 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: None

Participants: David Castro, Jordi Piguillem Poch, Martin Dougiamas and Tusefomal
Security Level: None
Resolved date: 16/Oct/08
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
add new groups

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tusefomal added a comment - 17/Sep/08 01:08 AM
The current implementation of this function is here:

http://cvs.moodle.org/contrib/patches/dfws/webservice/apis/group.lib.php?revision=1.1&view=markup

But for the API is necessary a massive function, I'm working on the new one but I have to know the params. By now, function gets courseid, groupname and groupdescription, but this params force to use an internal id course identifier. In other functions like get_users (http://tracker.moodle.org/browse/MDL-12887) and get_courses (http://tracker.moodle.org/browse/MDL-13128) the philosophy is to use a criteria param which determine the kind of identifier (id, idnumber...). In the other hand, I think that description is not a necessary param and can be deleted or threated in a group modifier function.

My proposal is:

/**

  • add a group to specified course
  • @param string criteria {idnumber, id, shortname}
  • @param string course: course key
  • @param string groupname
  • @return associative array groupname => integer (identifier if ok or -1 if error)
    */
    array add_groups (criteria,course,groupnames)

Group name in a course are unique and it's possible to use group name and course to identify it.


David Castro added a comment - 16/Oct/08 11:30 PM
Implemented and saved on CVS.

Jordi Piguillem Poch added a comment - 30/Jan/09 08:30 PM
I'm using groups_create_group() function to implement this WS.

I was thinking about checking that the courseid really exist before calling it, but it would be better to check it inside groups_create_group()....

Any clue or comment?