Moodle

auth/db should reset email when undeleting users

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: Authentication
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

moodle's delete_user function sets the email address to '' (used to be email || '.disabled') but in auth/db when users are undeleted it doesn't get reset. Not a huge problem as it'll get reset on next login (assuming the field is set to update on login as well as creation) but there could be try to email stuff to them in between account undeletion & email resetting on n ext login.

Issue Links

This issue duplicates:
MDL-13363 auth/db fails to undelete users, as the username field has been munged. Major Open
This issue has a non-specific relationship to:
MDL-13563 Hiding but not deleting users who are suspended in LDAP Major Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Luke Hudson added a comment -

Linked task is related to same area, and the attached patch only needs a couple of lines of modification to fix this issue. set_user_preferences(...) can be used to store the email address as well as the username.

Show
Luke Hudson added a comment - Linked task is related to same area, and the attached patch only needs a couple of lines of modification to fix this issue. set_user_preferences(...) can be used to store the email address as well as the username.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I do not like the way we delete users now - it is not proper delete because a lot of data is left in db, also the undelete is often hacky and it does not undo everything.

I always felt that deleting+undeleting of accounts in auth sync scripts is a bit messy and should not use standard delete at all. The patch makes sense in current code, but I think the (un)deletning in auth sync scripts should be completely rewritten in 2.0

Show
Petr Škoda (skodak) added a comment - I do not like the way we delete users now - it is not proper delete because a lot of data is left in db, also the undelete is often hacky and it does not undo everything. I always felt that deleting+undeleting of accounts in auth sync scripts is a bit messy and should not use standard delete at all. The patch makes sense in current code, but I think the (un)deletning in auth sync scripts should be completely rewritten in 2.0

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.