Issue Details (XML | Word | Printable)

Key: MDL-13173
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Gordon Bateson
Reporter: Matt Bockol
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

HotPot activities with quotes in their names have the name truncated when updated. Patch attached.

Created: 26/Jan/08 02:25 AM   Updated: 28/Jan/08 01:05 AM
Return to search
Component/s: Hotpot
Affects Version/s: 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4
Fix Version/s: 1.6.7, 1.7.5, 1.8.5

File Attachments: 1. File mod.html.patch.diff (0.5 kB)


Participants: Dan Poltawski, Gordon Bateson and Matt Bockol
Security Level: None
Resolved date: 28/Jan/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE


 Description  « Hide

HotPot activities with quotes in their names have the name truncated when you go to update them. These quotes are passed intact when populating the text box, truncating the value.

The attached patch applies the htmlspecialchars to $form->name in moodle/mod/hotpot/mod.html , converting the double quotes into html entities, correcting the problem.




 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Gordon Bateson added a comment - 26/Jan/08 05:36 PM
Thanks very much for reporting this and supplying the patch.

I have added the patch to Moodle 1.6, 1.7 and 1.8.

Moodle 1.9 and later do not use mod.html, so this is not an issue for those versions.

I confirmed I was able to add a HotPot activity with a quote in the name in all versions of Moodle 1.6 -> 2.0

If you have time, please confirm that the patched files in Moodle 1.6 -> 1.8 work for you.

many thanks
Gordon


Dan Poltawski added a comment - 28/Jan/08 01:05 AM
Resolving this bug