Moodle

timezone handling does not seem correct in stats

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

oserving weird time calculation problems in stats library - rewrite the time code using server timezone - do not rely on user timezone handling to prevent problems with skipped days, infinite loops, etc.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

The worst problem we face here are infinite looks and skipped days/weeks/months.
Critical days are DST transitions.
In general is is bad to mix native PHP and Moodle date handling functions, the code in patch was rewritten to prevent infinite looks and skipping.

TODO:

  • rewrite date handling in Moodle 2.0 using PHP5.2 date functions only - this should be much, much more reliable and accurate
Show
Petr Škoda (skodak) added a comment - The worst problem we face here are infinite looks and skipped days/weeks/months. Critical days are DST transitions. In general is is bad to mix native PHP and Moodle date handling functions, the code in patch was rewritten to prevent infinite looks and skipping. TODO:
  • rewrite date handling in Moodle 2.0 using PHP5.2 date functions only - this should be much, much more reliable and accurate
Hide
Permalink
Petr Škoda (skodak) added a comment -

done, special date related function implemented in stats

Show
Petr Škoda (skodak) added a comment - done, special date related function implemented in stats

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.