Issue Details (XML | Word | Printable)

Key: MDL-13204
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Iñaki Arenaza
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-19303

XMLDB check_indexes options runs for too long and PHP stops the script.

Created: 28/Jan/08 07:42 AM   Updated: 31/May/09 08:00 AM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 1.8.4
Fix Version/s: 1.8.10, 1.9.6, 2.0

Environment: Windows 2003, Apache 2.2.4, PHP 5.2.5, Oracle 10g

Database: Oracle
Participants: Eloy Lafuente (stronk7) and Iñaki Arenaza
Security Level: None
Resolved date: 31/May/09
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
When we try to check the database indexes from Admin->Misc->XMLDB editor->Check Indexes, after we confirm the run, we get a blank page after some time.

It seems index checking is taking longer than the configured max_execution_time and PHP stops executing the page. We should raise the execution time before calling '$xmldb_action->invoke();' to cater for this. I've tried with 'set_time_limit(0)' and it works ok, but I don't know the code so maybe this is a little bit too much and we could use a lower limit.

Saludos. Iñaki.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) made changes - 27/May/09 06:35 AM
Field Original Value New Value
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Parent MDL-19303 [ 32107 ]
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 31/May/09 07:45 AM
MDL-13204 xmlb editor checks - give extra time to checker because they can run looong
MODIFY admin/xmldb/actions/XMLDBCheckAction.class.php   Rev. 1.2    (+34 -27 lines)
Eloy Lafuente (stronk7) added a comment - 31/May/09 07:48 AM
I've fixed this for 2.0 because, on it, we are running all the tests with the XMLDBCheckAction base class, so I've implemented time limit extension there.

Going to backport that to 1.9 individual tests... now.


Eloy Lafuente (stronk7) made changes - 31/May/09 07:48 AM
Fix Version/s 1.9.6 [ 10340 ]
Fix Version/s 2.0 [ 10122 ]
Eloy Lafuente (stronk7) committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 31/May/09 07:55 AM
MDL-13204 execution time - give extra time to checker because they can run looong; backported from HEAD
MODIFY admin/xmldb/actions/check_indexes/check_indexes.class.php   Rev. 1.6.2.1    (+5 -1 lines)
MODIFY admin/xmldb/actions/check_bigints/check_bigints.class.php   Rev. 1.3.2.1    (+5 -1 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 31/May/09 07:58 AM
MDL-13204 execution time - give extra time to checker because they can run looong; backported from HEAD
MODIFY admin/xmldb/actions/check_indexes/check_indexes.class.php   Rev. 1.1.2.5    (+5 -1 lines)
Eloy Lafuente (stronk7) added a comment - 31/May/09 08:00 AM
Done the "extra" time fix has been backported both to 19_STABLE (check indexes and bigints) and 18_STABLE (check indexes).

Resolving as fixed, agur!


Eloy Lafuente (stronk7) made changes - 31/May/09 08:00 AM
Resolution Fixed [ 1 ]
Fix Version/s 1.8.10 [ 10350 ]
Status Open [ 1 ] Resolved [ 5 ]