Issue Details (XML | Word | Printable)

Key: MDL-13232
Type: Sub-task Sub-task
Status: Reopened Reopened
Priority: Minor Minor
Assignee: Mathieu Petit-Clair
Reporter: Dan Poltawski
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13404

Inconsistent tag display capitilisation

Created: 30/Jan/08 12:15 AM   Updated: 21/Nov/08 10:37 PM
Return to search
Component/s: Tags
Affects Version/s: 1.9
Fix Version/s: None

Participants: Dan Poltawski, Martin Dougiamas, Mathieu Petit-Clair and N Hansen
Security Level: None
Resolved date: 25/Feb/08
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Create tags:

Moodle, HE, cat

In the tag cloud their original case is kept.
In blog tags list/interest their are lowercased apart from first letter

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Mathieu Petit-Clair added a comment - 12/Feb/08 12:23 PM
I just had a discussion with Martin about this feature, which is apparently because in some languages (German?) the meaning changes with the capitalization of words. I agree it might be better to make this consistent throughout the user interface.

The database contains two fields : name and rawname. "name" is used for internal comparison, while "rawname" is used to display the tag.

Should this be changed for the tag cloud?


Mathieu Petit-Clair made changes - 12/Feb/08 12:24 PM
Field Original Value New Value
Parent MDL-13404 [ 24825 ]
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Mathieu Petit-Clair added a comment - 25/Feb/08 04:59 PM
There is an admin setting, under security->site policies, called keeptagnamecase, that determines wether to keep the original capitalization (default) or to use the lowercase equivalent (when possible, per locale).

I believed (after testing) that we fixed it so that this setting is used everywhere.


Mathieu Petit-Clair made changes - 25/Feb/08 04:59 PM
Status Open [ 1 ] Resolved [ 5 ]
Assignee Luiz Cruz [ luiz.laydner ] Mathieu Petit-Clair [ scyrma ]
Resolution Fixed [ 1 ]
N Hansen added a comment - 01/Jun/08 08:45 AM
Well, it certainly is doing odd things still here on Moodle.org. I typed the following:

Egypt, cooking, Ancient Egypt, hooping, eLearning

in my profile. And here is how it displayed it:

egypt, Cooking, ancient egypt, hooping, ELearning

Which follows no rules that I can ascertain.


N Hansen made changes - 01/Jun/08 08:45 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Martin Dougiamas added a comment - 02/Jun/08 09:52 PM
The tag that is shown is the case used by the first person ever to use the tag. So when you typed "Egypt" it found "egypt" and linked you to that, and shows "egypt" everywhere it needs to. You could go to the tag (http://moodle.org/tag/index.php?tag=egypt) and edit it to fix it if you like.

Martin Dougiamas added a comment - 02/Jun/08 09:53 PM
Added n hansen as watcher.

Mathieu Petit-Clair added a comment - 13/Jun/08 10:08 AM
This behavior is configurable by the administrator. In Admin -> Security -> Site policies, if you toggle "keeptagnamecase" (to no, instead of default "yes"), tags will be displayed with a capitalized first letter, the rest in lower case.

moodle.org chose to keep the names as they are entered the first time. In the example given above, the first user who chose to use the tag "egypt" entered it without a capital 'E', so that's how it's displayed for everybody. Egypt, being the name of a country, should be capitalized ... but the first user chose not to. If it's really an issue, the admin can correct it in the "manage tags" interface...

It would be possible to save tags using the exact casing the user provides, but that would add a level of complexity, anytime we display/compare/count tags (so that people using 'egypt' are still linked with 'Egypt' too, for example). I'm sure there are issues with different locales too.


N Hansen added a comment - 21/Nov/08 10:37 PM
That does not explain the problem, as I am the FIRST and ONLY person to use that tag and I am 100% certain I entered it as Egypt not egypt.