|
Eloy, I made a patch here, please review, if it is good, I will commit to CVS, thanks.
This patch is against HEAD.
Please ignore my previous patch, try this latest one.
Hi Dongsheg some comments about your patch:
1) Icons aren't displayed properly. It seems that the extension is missing in the icons. Plz, send a patch fixing all these. TIA! Backporting to 19_STABLE will require to backport also Ciao Eloy,I attached another patch which fixed 2), 3), 4)
What do you mean extension is missing, I got the emoticons from $CFG->emoticons, is this wrong? The new patch, fix all known problems
Thanks Dongsheng, can you put this in HEAD? I think it's OK for 1.9 too but I'd like to test it a little first.
Committed to HEAD only, please review, feel free to reopen if you find any problem or this change need to backport to moodle 1.9.
reopening this a bit...
1) <li> elements aren't closed. Both 1 & 2 causes XHTML breakage. Can you fix them, plz. TIA and ciao P.S: Trick: it's highly recommended to have FF with some nice extensions installed (Web Developer Extension, HTML Validator...). And highly recommended to check that pages we are committing are, always, valid XHTML. Fixed, tested, Thanks, Eloy.
Feel free to reopen.. Feeling happy to close! :-P Thanks!
The fixing of this issue modifies substantially 3 help files:
*help/emoticons.html *help/text.html *help/richtext.html which breaks backward compatibility in lang packs. Our policy would be to create new files emoticons2.html, etc. or am I wrong ? Ah ,crap!
I forgot that completely! Well spotted Nicolas! Hi Dongsheng. The cause for this is that other langs only have one version (HEAD) but English has one version per release. And if we change the en_utf8 help files in HEAD as we have done, soon other translators will change their HEAD languages too... but that will break those help files when used in older Moodle releases because old Moodle releases don't know about the #emoticons_html# thing at all. This means that... 1) We must revert to previous versions of: *help/emoticons.html 2) We must create new versions of them, called: *help/emoticons2.html 3) We must go across all Moodle (HEAD) code and switch all the uses of old files to the new ones. TIA & ciao Put a patch here, all the helpbuttons are fixed(`grep "helpbutton(.*(text|richtext|emoticons)" -r /var/www/dev`)
Fixed in HEAD, please review, feel free to reopen, thanks
 Hi Dongsheng,
I think everything is ok... B-) just found one "strange" commit: http://cvs.moodle.org/moodle/lib/javascript.php?r1=1.38&r2=1.39 What is that intended for? Ciao This commit can fix a javascript error, if the parent window is not existed, it will stop here.
aha. Cool! Thanks!
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Minor
Emoticons Documentation should be dynamic with the new configuration settings
 |
|
htmlof help files).What if we try to address this as follows:
1) Create one function, call it: get_emoticons_html() responsible to look for current emotions defined and generate the proper HTML (the "table" of emoticons).
2) In the emoticons help page (and others where present), delete the "table" of emoticons and insert something like:
#emoticons_html#
3) that "tag" will be parsed by help.php replacing the tag with the calculated table.
Both the parsing and get_emoticons_html() function must be within help.php.
Assigning to Dongsheng... discuss and confirm with MD before, please.
Any idea will be welcome, of course! Ciao