Moodle

USERS section is processed twice one restore, only one should be necessary

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: STABLE backlog
  • Component/s: Backup, Roles / Access
  • Labels:
    None
  • Environment:
    Any
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE

Description

I was playing with MDL-6856, and while debugging, I've detected that the <USERS> section in backup files is processed twice, one for creating users (and associated data like preferences, tags...) and another one to process role assignments and role overrides.

IMO, the second XML parsing should be unnecessary because all the data is stored (role assignments and role overrides includes) in the first pass.

Try to avoid the second pass and access to saved data. Will be really noticeable in courses with a lot lot of users!

Issue Links

Activity

Hide
Martin Dougiamas added a comment -

Pushing later as it's a performance thing only

Show
Martin Dougiamas added a comment - Pushing later as it's a performance thing only
Hide
Eloy Lafuente (stronk7) added a comment -

Moving this to next release, I think I could try that when I retake the backup thing in 2 weeks from now.

Although it's not critical at all, and perhaps will require too much changes (prone to error) in stable. Will be analysed, anyway, before deciding between stable/head.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Moving this to next release, I think I could try that when I retake the backup thing in 2 weeks from now. Although it's not critical at all, and perhaps will require too much changes (prone to error) in stable. Will be analysed, anyway, before deciding between stable/head. Ciao

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated: