Issue Details (XML | Word | Printable)

Key: MDL-13296
Type: Sub-task Sub-task
Status: Open Open
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 1
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13847

USERS section is processed twice one restore, only one should be necessary

Created: 03/Feb/08 05:20 AM   Updated: 21/Oct/09 04:17 PM
Return to search
Component/s: Backup, Roles
Affects Version/s: 1.9
Fix Version/s: 1.9.7

Environment: Any
Issue Links:
Relates
 

Database: Any
Participants: Eloy Lafuente (stronk7) and Martin Dougiamas
Security Level: None
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
I was playing with MDL-6856, and while debugging, I've detected that the <USERS> section in backup files is processed twice, one for creating users (and associated data like preferences, tags...) and another one to process role assignments and role overrides.

IMO, the second XML parsing should be unnecessary because all the data is stored (role assignments and role overrides includes) in the first pass.

Try to avoid the second pass and access to saved data. Will be really noticeable in courses with a lot lot of users!

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 25/Feb/08 05:34 PM
Pushing later as it's a performance thing only

Eloy Lafuente (stronk7) added a comment - 08/May/09 08:10 AM
Moving this to next release, I think I could try that when I retake the backup thing in 2 weeks from now.

Although it's not critical at all, and perhaps will require too much changes (prone to error) in stable. Will be analysed, anyway, before deciding between stable/head.

Ciao