Moodle

ufo.js library works badly with IE7

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.4, 1.8.5, 1.9
  • Fix Version/s: 2.0
  • Component/s: Filters
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Flash based objects are not being embedded in IE7 if the page takes too long to load.

Reason for bug:

moodle/lib/ufo.js uses a poorly written domLoad function.
It uses a time out of 250 milliseconds as an IE7 domload check. If the page takes longer than 250 milliseconds to load then the flash object will not be embedded.

Possible Solutions:
1) Ditch ufo and use swfobject instead (the guy who wrote ufo.js now works on this project)

2) Use the attached ufo.js (modified by me)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Dongsheng, can you fix ufo.js as described and test it still works in older IE and older Firefox etc?

Show
Martin Dougiamas added a comment - Dongsheng, can you fix ufo.js as described and test it still works in older IE and older Firefox etc?
Hide
Permalink
Dongsheng Cai added a comment -

Tested in firefox 2, ie6 and 7, safari, it worked, committed to HEAD for more testing, backport to moodle 1.9 and 1.8.

Show
Dongsheng Cai added a comment - Tested in firefox 2, ie6 and 7, safari, it worked, committed to HEAD for more testing, backport to moodle 1.9 and 1.8.
Hide
Permalink
guy thomas added a comment -

Dongsheng, thanks for testing this and committing it.
It was driving me mad with Internet Explorer!

Show
guy thomas added a comment - Dongsheng, thanks for testing this and committing it. It was driving me mad with Internet Explorer!
Hide
Permalink
Anthony Borrow added a comment -

Dongsheng and Guy - You both have more experience with the ufo.js file. The ufo website (http://www.bobbyvandersluis.com/ufo/index.html) indicates that the code is now officially deprecated in favor of swfobject.js (http://code.google.com/p/swfobject/). For Moodle 2.0, should we look at using the swfobject.js instead? Peace - Anthony

Show
Anthony Borrow added a comment - Dongsheng and Guy - You both have more experience with the ufo.js file. The ufo website (http://www.bobbyvandersluis.com/ufo/index.html) indicates that the code is now officially deprecated in favor of swfobject.js (http://code.google.com/p/swfobject/). For Moodle 2.0, should we look at using the swfobject.js instead? Peace - Anthony
Hide
Permalink
Amy Groshek added a comment -

Yes, we should be switching to swfobject instead!!!

Show
Amy Groshek added a comment - Yes, we should be switching to swfobject instead!!!
Hide
Permalink
Daniel Wahl added a comment -

This is marked as fixed, but as I just tested with webpagetest.org with IE7 ufo.js was still the culprit of a 20+ second load delay when viewing a page with an embedded flash object on 1.9+. Since the affected versions are 1.8+ and the fix is 2.0+ should the versions <2.0 be considered 'will not fix'?

Show
Daniel Wahl added a comment - This is marked as fixed, but as I just tested with webpagetest.org with IE7 ufo.js was still the culprit of a 20+ second load delay when viewing a page with an embedded flash object on 1.9+. Since the affected versions are 1.8+ and the fix is 2.0+ should the versions <2.0 be considered 'will not fix'?

People

Vote (5)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.