Moodle

stats graphs broken if timezone or dst changes

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

problem is that the stats UI expects the exact day end timestapts in db which is wrong, because site may change timezone, dst, ect.
solution: add date normalization into stats_fix_zeros()

Issue Links

This issue has a non-specific relationship to:
MDL-12031 After switch from daylight savings to standard time, course>partcipants>activity reports>all logs: graph of hits on course by user shows two Sundays and log entries are shown under wrong day. Major Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Spall added a comment -

Is this the underlying reason for the DST issue in MDL-12031?

Show
Michael Spall added a comment - Is this the underlying reason for the DST issue in MDL-12031?
Hide
Permalink
Petr Škoda (skodak) added a comment -

stats uses a bit different logic than logs, though the problem is similar; it is a bit hacky at present, I hope it will solved finally when we switch to native PHP 5.2.x date functions in Moodle 2.0

Show
Petr Škoda (skodak) added a comment - stats uses a bit different logic than logs, though the problem is similar; it is a bit hacky at present, I hope it will solved finally when we switch to native PHP 5.2.x date functions in Moodle 2.0
Hide
Permalink
Petr Škoda (skodak) added a comment -

done

Show
Petr Škoda (skodak) added a comment - done

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.