Moodle

/my moodle edit button inconsistency

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 2.0
  • Component/s: Accessibility, Language, Usability
  • Labels:
    None
  • Environment:
    ALL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The my Moodle's "Edit this page" and "Normal mode" buttons are wildly inconsistent compared to the course page's more standard "Turn editing on" and "Turn editing off" buttons, which make sense to newcomers.

Issue Links

This issue will be resolved by:
MDL-19124 My Moodle Functional Overhaul Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ray Lawrence added a comment -

Not sure it's that wild but +1 for this change from me.

Show
Ray Lawrence added a comment - Not sure it's that wild but +1 for this change from me.
Hide
Permalink
Martin Dougiamas added a comment -

Steve, you can find the "Turn ..." language strings used on /course/view.php (look for get_string(...))

These should be used instead of the ones that are used on /my/index.php

Then make a diff and attach a patch here on this bug, thanks!

Show
Martin Dougiamas added a comment - Steve, you can find the "Turn ..." language strings used on /course/view.php (look for get_string(...)) These should be used instead of the ones that are used on /my/index.php Then make a diff and attach a patch here on this bug, thanks!
Hide
Permalink
Mark Drechsler added a comment -

Hi Martin,

Does this bug also cover the issue of the 'My Moodle' edit button not disappearing even when users are restricted from editing their My Moodle page? I've tried this in 1.9.2 and even though the edit button doesn't do anything, it still appears and seems a bit confusing.

Cheers,

Mark.

Show
Mark Drechsler added a comment - Hi Martin, Does this bug also cover the issue of the 'My Moodle' edit button not disappearing even when users are restricted from editing their My Moodle page? I've tried this in 1.9.2 and even though the edit button doesn't do anything, it still appears and seems a bit confusing. Cheers, Mark.
Hide
Permalink
Daniel Neis added a comment -

Hello,

there is a patch to correct this issue.
Hope you like.

Show
Daniel Neis added a comment - Hello, there is a patch to correct this issue. Hope you like.
Hide
Permalink
Anthony Borrow added a comment -

Daniel - As I understand this is not so much a patch as a change to the language string being used. I like the idea of being consistent and as mentioned this can be accomplished by changing the language string. I think it would be best for Moodle 2.0. My hesitation in changing it in Moodle 1.9 is that it may cause a little confusion (although I really doubt it would cause much) for folks used to seeing the current version of 'Edit this page' vs. 'Turn editing on'. It seems like a trivial issue. Am I missing something in the patch? Personally I find the single quotes more readable as it avoids having to escape the double quote but that is stylistic. Peace - Anthony

Show
Anthony Borrow added a comment - Daniel - As I understand this is not so much a patch as a change to the language string being used. I like the idea of being consistent and as mentioned this can be accomplished by changing the language string. I think it would be best for Moodle 2.0. My hesitation in changing it in Moodle 1.9 is that it may cause a little confusion (although I really doubt it would cause much) for folks used to seeing the current version of 'Edit this page' vs. 'Turn editing on'. It seems like a trivial issue. Am I missing something in the patch? Personally I find the single quotes more readable as it avoids having to escape the double quote but that is stylistic. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I am dropping priority to trivial since the work around is fairly simple. Peace - Anthony

Show
Anthony Borrow added a comment - I am dropping priority to trivial since the work around is fairly simple. Peace - Anthony
Hide
Permalink
Daniel Neis added a comment -

Anthony - the patch is essentialy the language string change. The rest is realy just for a better readability of the code, but of course is a biased change. Thanks for the attention - Daniel.

Show
Daniel Neis added a comment - Anthony - the patch is essentialy the language string change. The rest is realy just for a better readability of the code, but of course is a biased change. Thanks for the attention - Daniel.
Hide
Permalink
Robert Russo added a comment -

This is exactly just a change in the language string.

Show
Robert Russo added a comment - This is exactly just a change in the language string.
Hide
Permalink
Anthony Borrow added a comment -

Robert - I am looking forward to seeing you soon in Orlando. Since this is a language string issue and easily worked around on 1.9 sites by creating a localized language string I am going to set the fix version to Moodle 2.0 where it could be considered a usability improvement or perhaps it may be decided not to fix it. It does not strike me as something that should be changed in Moodle 1.9 since it is supposed to be stable. I am also going to assign this to Koen since it is really a language issue. Peace - Anthony

Show
Anthony Borrow added a comment - Robert - I am looking forward to seeing you soon in Orlando. Since this is a language string issue and easily worked around on 1.9 sites by creating a localized language string I am going to set the fix version to Moodle 2.0 where it could be considered a usability improvement or perhaps it may be decided not to fix it. It does not strike me as something that should be changed in Moodle 1.9 since it is supposed to be stable. I am also going to assign this to Koen since it is really a language issue. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Koen - This appears to be more of a language issue which may want to consider improving in Moodle 2.0 to provide greater consistency. I'm assigning it to you for consideration but feel free to comment and re-assign as appropriate. Peace - Anthony

Show
Anthony Borrow added a comment - Koen - This appears to be more of a language issue which may want to consider improving in Moodle 2.0 to provide greater consistency. I'm assigning it to you for consideration but feel free to comment and re-assign as appropriate. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I am tagging this as an accessibility, language and usability issue (removing general and other)

Show
Anthony Borrow added a comment - I am tagging this as an accessibility, language and usability issue (removing general and other)
Hide
Permalink
Koen Roggemans added a comment -

I aggree this should be changed, but since it is English, it goes to Helen: she is going to check the English language pack for Moodle 2.0

Show
Koen Roggemans added a comment - I aggree this should be changed, but since it is English, it goes to Helen: she is going to check the English language pack for Moodle 2.0
Hide
Permalink
Helen Foster added a comment -

Thanks everyone for your comments and votes. Just linking this issue to MDL-19124 - My Moodle Functional Overhaul for Moodle 2.0.

Show
Helen Foster added a comment - Thanks everyone for your comments and votes. Just linking this issue to MDL-19124 - My Moodle Functional Overhaul for Moodle 2.0.
Hide
Permalink
Helen Foster added a comment -

Closing this issue as I've checked and found that the button has been changed to 'Customise this page' / 'Stop customising this page'. I guess students are not familiar with 'Turn editing on/off' so this is perhaps better for them.

Show
Helen Foster added a comment - Closing this issue as I've checked and found that the button has been changed to 'Customise this page' / 'Stop customising this page'. I guess students are not familiar with 'Turn editing on/off' so this is perhaps better for them.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.