[#MDL-13481] Distinguish between course "fullname" and user "fullname"

Issue Details (XML | Word | Printable)

Key:	MDL-13481
Type:	Bug
Status:	Reopened
Priority:	Minor
Assignee:	David Mudrak
Reporter:	David Mudrak
Votes:	1
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Distinguish between course "fullname" and user "fullname"

Created: 15/Feb/08 07:13 PM Updated: 21/Jul/08 10:37 AM

Return to search

Component/s:

Languages

Affects Version/s:

1.9

Fix Version/s:

2.0

Issue Links:

Relates

This issue has been marked as being related by:

~~MDL-10972~~ Do not use "Full name" in exported quiz results sheet

Participants:	David Mudrak, Dongsheng Cai, Koen Roggemans and Martin Dougiamas
Security Level:	None
QA Assignee:	Nicolas Martignoni
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

At the moment, the get_string('fullname', 'moodle') is used for both course fullname (e.g. in course/edit_form.php) and for user fullname (e.g. admin/user/usert_bulk.php). This causes problems in languages where different words should be used for names of persons and for names of things.

There is a proposal to introduce new strings "coursefullname", "courseshortname" instead of current "fullname" and "shortname" and keep "fullname" (or even better new "userfullname") for user full name only.

All

Comments

Change History

Version Control

Sort Order:

Koen Roggemans made changes - 15/Feb/08 07:31 PM

Field	Original Value	New Value
Assignee	Koen Roggemans [ koen ]	Martin Dougiamas [ dougiamas ]

[ Permalink | « Hide ]

Koen Roggemans added a comment - 15/Feb/08 07:32 PM

m.i. It should be two new strings for backward compatability

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 19/Mar/08 02:38 PM

Dongsheng, we need to add two strings coursefullname and userfullname in lang/en_utf8/moodle.php and carefully fix all the places where get_string('fullname') was used so that it's either get_string('coursefullname') or get_string('userfullname') as appropriate. Just in HEAD, thanks.

Martin Dougiamas made changes - 19/Mar/08 02:38 PM

Assignee

Martin Dougiamas [ dougiamas ]

Dongsheng Cai [ dongsheng ]

Martin Dougiamas made changes - 19/Mar/08 02:39 PM

Fix Version/s

2.0 [ 10122 ]

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 19/Mar/08 02:40 PM

Actually fullnameuser and fullnamecourse would be better names (puts them next to each other for translators).

Dongsheng Cai committed 12 files to 'Moodle CVS' - 19/Mar/08 05:49 PM

MDL-13481, Distinguish between course fullname and user fullname

MODIFY	user/groupextendenrol.php	Rev. 1.4	(+2 -2 lines)
MODIFY	user/filters/lib.php	Rev. 1.3	(+2 -2 lines)
MODIFY	lang/en_utf8/moodle.php	Rev. 1.174	(+6 -2 lines)
MODIFY	user/extendenrol.php	Rev. 1.13	(+2 -2 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.316	(+2 -2 lines)
MODIFY	course/lib.php	Rev. 1.566	(+6 -6 lines)
MODIFY	course/request_form.php	Rev. 1.13	(+3 -3 lines)
MODIFY	mod/resource/type/file/Attic/resource.class.php	Rev. 1.79	(+4 -4 lines)
MODIFY	user/index.php	Rev. 1.208	(+2 -2 lines)
MODIFY	mod/resource/type/repository/Attic/resource.class.php	Rev. 1.23	(+4 -4 lines)
MODIFY	course/edit_form.php	Rev. 1.42	(+5 -5 lines)
MODIFY	course/pending.php	Rev. 1.13	(+2 -2 lines)

Nicolas Martignoni made changes - 19/Mar/08 06:51 PM

QA Assignee

mina

[ Permalink | « Hide ]

David Mudrak added a comment - 19/Mar/08 07:19 PM

Please, is there any chance to backport this into MOODLE_19_STABLE? It is very difficult to find an translation of "fullname" in both user and course context. If this fix is intended for 2.0 only, I will have to live with messy language pack for the whole long 1.9 live cycle

Moreover, I would have to change the Moodle terminology now and then again in 2.0

Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 19/Mar/08 09:51 PM

Translated new strings for course fullname and user fullname MDL-13481.
Updated a help file for course fullname.
Updated a translated string for enrol database.

MODIFY	ja_utf8/help/coursefullname.html	Rev. 1.3	(+2 -2 lines)
MODIFY	ja_utf8/enrol_database.php	Rev. 1.11	(+1 -1 lines)
MODIFY	ja_utf8/README	Rev. 1.665	(+1 -1 lines)
MODIFY	ja_utf8/moodle.php	Rev. 1.286	(+4 -0 lines)