Moodle

Add xmlrpc extension to environment check

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.5, 1.9
  • Component/s: Installation
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

In checking for the various php extensions which ought to be installed, it would be nice if we added a check for the xmlrpc module and gave a warning if it is not there to let users know that they will not be able to use the Moodle Networking features without it.

Issue Links

This issue has a clone:
MDL-12080 Add one optional environmental check about xml-rpc installed Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Martin - Here is a diff file that should provide for checking the presence of the xmlrpc extension. I think this should be present for Moodle 1.8 forward. Peace - Anthony

Show
Anthony Borrow added a comment - Martin - Here is a diff file that should provide for checking the presence of the xmlrpc extension. I think this should be present for Moodle 1.8 forward. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

When doing an install on my localhost, I noticed that during the install, it appears that the variable for the docs directory was not declared producing invalid links to these files. It's a separate issue but I figured I would document it here since it is likely an easy fix. Peace - Anthony

Show
Anthony Borrow added a comment - When doing an install on my localhost, I noticed that during the install, it appears that the variable for the docs directory was not declared producing invalid links to these files. It's a separate issue but I figured I would document it here since it is likely an easy fix. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Just to follow up, in 19STABLE branch, it appears that the environment check page does not even provide a link in the report column when checking for the various php extensions.

Show
Anthony Borrow added a comment - Just to follow up, in 19STABLE branch, it appears that the environment check page does not even provide a link in the report column when checking for the various php extensions.
Hide
Permalink
Anthony Borrow added a comment -

Here is a patch that takes care of both the doc_link function in /lib/weblib.php that was causing bad links to be created. It makes sense to me that we would default to docs.moodle.org if there is nothing defined in $CFG. I'm not sure why it was returning '' if it was not set. Would the desired behavior otherwise be that we want no documentation? If so, we would need to change that to check to see if we are installing and if so then set the documentation directory to docs.moodle.org. The patch also adds the appropriate language string to admin.php and xmlrpc php extension checks for version 1.8, 1.9 and 2.0.

Show
Anthony Borrow added a comment - Here is a patch that takes care of both the doc_link function in /lib/weblib.php that was causing bad links to be created. It makes sense to me that we would default to docs.moodle.org if there is nothing defined in $CFG. I'm not sure why it was returning '' if it was not set. Would the desired behavior otherwise be that we want no documentation? If so, we would need to change that to check to see if we are installing and if so then set the documentation directory to docs.moodle.org. The patch also adds the appropriate language string to admin.php and xmlrpc php extension checks for version 1.8, 1.9 and 2.0.
Hide
Permalink
Anthony Borrow added a comment -

Here is a 19STABLE patch. I created a separate patch because of minor changes to /lib/weblib.php doc_link function. With respect to admin.php and environment.xml the changes are the same.

Show
Anthony Borrow added a comment - Here is a 19STABLE patch. I created a separate patch because of minor changes to /lib/weblib.php doc_link function. With respect to admin.php and environment.xml the changes are the same.
Hide
Permalink
Martin Dougiamas added a comment -

I've checked this in (with the change I've set $CFG->docroot in install.php instead because we do want no path to mean "don't print docs")

Thanks!

Show
Martin Dougiamas added a comment - I've checked this in (with the change I've set $CFG->docroot in install.php instead because we do want no path to mean "don't print docs") Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.