[#MDL-13554] Block restore for modules can fail or insert invalid block_instance records - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 1.8.4
Fix Version/s: 1.8.5, 1.9
Component/s: Backup
Labels:
None

Affected Branches:
MOODLE_18_STABLE
Fixed Branches:
MOODLE_18_STABLE, MOODLE_19_STABLE

Description

In the backup process, all block from all modules are backed up regardless if the module has been selected for backup. So, during the restore process, the block restore code never checks to see if the pageid remaps correctly. This results in the pageid being set to NULL, causing the restore to fail, or the pageid being set to 0, creating an invalid block_instance record.

Attached is a fix in the restore process. A further fix would be to only backup those blocks that belong to modules that are actually being backed up. Regardless though, I think the attached patch should be added to restorelib.php.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

restorelib.diff

21/Feb/08 4:52 AM

0.6 kB

Mark Nielsen

Activity

Hide

Permalink

Martin Dougiamas added a comment - 21/Feb/08 2:29 PM

Thanks Mark.

Eloy, I've checked this in as it's so small and seems to make sense. I'd be happy if you have any time to just run an eye over it though.

Show

Martin Dougiamas added a comment - 21/Feb/08 2:29 PM Thanks Mark. Eloy, I've checked this in as it's so small and seems to make sense. I'd be happy if you have any time to just run an eye over it though.

People

Assignee:

Eloy Lafuente (stronk7)

Reporter:

Mark Nielsen

Participants:

Eloy Lafuente (stronk7), Mark Nielsen, Martin Dougiamas

Vote (0)

Watch (1)

Dates

Created:

21/Feb/08 4:52 AM

Updated:

17/Dec/10 1:01 PM

Resolved:

21/Feb/08 2:36 PM