Moodle

Restore: Gradebook - fix restore so that drop x lowest grades for a category is imported into 1.9 gradebook

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Backup, Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The course backup attached to MDL-13617 indicates that 1 assignment from the uncategorized category is to be dropped from the grade in the calculation. However, that information is not imported into the 1.9 gradebook. This may cause some confusion when bringing the grades over; however, it is technically a loss of data and thus seems to be a major priority.

Activity

Hide
Petr Škoda (skodak) added a comment -

should be fixed now, thanks

Show
Petr Škoda (skodak) added a comment - should be fixed now, thanks
Hide
Anthony Borrow added a comment -

Petr - I'm reopening since I just tried to restore the zip file mentioned and it does not show that the uncategorized grade category which I would imagine should restore as the main total (i.e. parent or top category) is to drop the lowest 1 grades. Perhaps this works when there are multiple categories in the course but in this example it does not seem to be working. That being said a record is created in the grade_categories table:

parent: NULL
depth: 1
path: /10/
fullname: ?
aggregation: 0
keephigh: 0
droplow: 0
aggregateonlygraded: 0
aggregateoutcomes: 0
aggregatesubcats: 0

Show
Anthony Borrow added a comment - Petr - I'm reopening since I just tried to restore the zip file mentioned and it does not show that the uncategorized grade category which I would imagine should restore as the main total (i.e. parent or top category) is to drop the lowest 1 grades. Perhaps this works when there are multiple categories in the course but in this example it does not seem to be working. That being said a record is created in the grade_categories table: parent: NULL depth: 1 path: /10/ fullname: ? aggregation: 0 keephigh: 0 droplow: 0 aggregateonlygraded: 0 aggregateoutcomes: 0 aggregatesubcats: 0
Hide
Petr Škoda (skodak) added a comment -

Was it a restore into new course, right?

Show
Petr Škoda (skodak) added a comment - Was it a restore into new course, right?
Hide
Anthony Borrow added a comment -

Petr - Yes, I restored from a frontpage restore to a new course.

Show
Anthony Borrow added a comment - Petr - Yes, I restored from a frontpage restore to a new course.
Hide
Petr Škoda (skodak) added a comment -

I hope it is fixed now, please reopen again if needed
thanks

Show
Petr Škoda (skodak) added a comment - I hope it is fixed now, please reopen again if needed thanks
Hide
Anthony Borrow added a comment -

Petr - The restore works fine and the number of exclusions is in the main category. The only thing I noticed was that the assignments seem to be in the reverse order (starting with assignment 5). Let me know if you want me to open a separate tracker request for that issue. I'll attach a screenshot of the restored course. The only difference was this time I was using postgresql. I'll test on mysql to see if there is any difference. Peace - Anthony

Show
Anthony Borrow added a comment - Petr - The restore works fine and the number of exclusions is in the main category. The only thing I noticed was that the assignments seem to be in the reverse order (starting with assignment 5). Let me know if you want me to open a separate tracker request for that issue. I'll attach a screenshot of the restored course. The only difference was this time I was using postgresql. I'll test on mysql to see if there is any difference. Peace - Anthony
Hide
Anthony Borrow added a comment -

Here is the screenshot showing the reverse order of the restored assignments.

Show
Anthony Borrow added a comment - Here is the screenshot showing the reverse order of the restored assignments.
Hide
Petr Škoda (skodak) added a comment -

should be fixed now too

Show
Petr Škoda (skodak) added a comment - should be fixed now too
Hide
Anthony Borrow added a comment -

Petr - I'm not sure its a problem but the metacourse options seemed a bit far over to the right. I suspect something trivial but am rushing off and don't have time to look at it. Also, I attempted another restore and order still seemed to be reversed but I will confirm that is the case as I was rushing through it. Peace - Anthony

Show
Anthony Borrow added a comment - Petr - I'm not sure its a problem but the metacourse options seemed a bit far over to the right. I suspect something trivial but am rushing off and don't have time to look at it. Also, I attempted another restore and order still seemed to be reversed but I will confirm that is the case as I was rushing through it. Peace - Anthony

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: