Moodle

lib/phpxml/xml.php causes notice about pass by reference

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The note on http://keithdevens.com/software/phpxml explains the issue.

We should leave it as it is for Moodle 1.9.

I'm going to change the file in Moodle 2.0 because we have PHP 5.2 as a minimum and it's OK to remove the pass-by-reference.

Issue Links

This issue is duplicated by:
MDL-14824 Notice in Youtube Block Minor Closed
This issue has been marked as being related by:
MDL-11960 cannot configure rss block on tag page Major Open

Activity

Hide
Permalink
Martin Dougiamas added a comment -

For reference, this was the notice in PHP5:

"Notice: Only variable references should be returned by reference in /moodle/19/lib/phpxml/xml.php on line 73"

Show
Martin Dougiamas added a comment - For reference, this was the notice in PHP5: "Notice: Only variable references should be returned by reference in /moodle/19/lib/phpxml/xml.php on line 73"

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.