[#MDL-13636] URL encoding is popping up where it shouldn't

Issue Details (XML | Word | Printable)

Key:	MDL-13636
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Mathieu Petit-Clair
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-13594

URL encoding is popping up where it shouldn't

Created: 25/Feb/08 12:31 PM Updated: 25/Feb/08 04:12 PM

Return to search

Component/s:

Tags

Affects Version/s:

1.9

Fix Version/s:

1.9

File Attachments:

None

Image Attachments:

1. screenshot-1.jpg
(38 kB)

Database:	MySQL
Participants:	Martin Dougiamas and Mathieu Petit-Clair
Security Level:	None
Resolved date:	25/Feb/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

I made a tag called: ;;;cool;;;

It looks like the screenshot on

- related tags on tag/index.php and
- related tags in form on tag/edit.php

All

Comments

Change History

Version Control

Sort Order:

Martin Dougiamas made changes - 25/Feb/08 12:31 PM

Field	Original Value	New Value
Attachment		screenshot-1.jpg [ 13205 ]

Mathieu Petit-Clair committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/Feb/08 02:47 PM

~~MDL-13639~~ - use tag_find_tags, MDL-13404 - improve documentation in the file, ~~MDL-13636~~ - partial fix

MODIFY	tag/tag_autocomplete.php	Rev. 1.3.2.5	(+2 -2 lines)
MODIFY	tag/search.php	Rev. 1.5.2.5	(+1 -1 lines)
MODIFY	tag/edit.php	Rev. 1.5.2.5	(+3 -3 lines)
MODIFY	tag/lib.php	Rev. 1.43.2.21	(+56 -57 lines)
MODIFY	tag/locallib.php	Rev. 1.1.2.6	(+12 -10 lines)

[ Permalink | « Hide ]

Mathieu Petit-Clair added a comment - 25/Feb/08 02:50 PM

The ajax pop-up is displayed the right way, but it's still inserting htmlspecialchars-encoded data in the textarea.

Mathieu Petit-Clair made changes - 25/Feb/08 02:50 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Mathieu Petit-Clair committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/Feb/08 04:05 PM

~~MDL-13636~~ - Modification to the YUI autocomplete call, to show and use the right strings

MODIFY	tag/tag_autocomplete.php		Rev. 1.3.2.6		(+3 -3 lines)
MODIFY	tag/edit.php		Rev. 1.5.2.7		(+4 -1 lines)

Mathieu Petit-Clair committed 2 files to 'Moodle CVS' - 25/Feb/08 04:10 PM

~~MDL-13636~~ - merge from 1.9

MODIFY	tag/edit.php		Rev. 1.12		(+4 -1 lines)
MODIFY	tag/tag_autocomplete.php		Rev. 1.8		(+3 -3 lines)

[ Permalink | « Hide ]

Mathieu Petit-Clair added a comment - 25/Feb/08 04:12 PM

This should be fixed now. I found some useful information on http://developer.yahoo.com/yui/autocomplete/#formatting

Mathieu Petit-Clair made changes - 25/Feb/08 04:12 PM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.