Moodle

Backup: unserialize notice when making course backup

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: STABLE backlog
  • Component/s: Backup
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

During a course backup I am seeing the following notice:

Notice: unserialize() [function.unserialize]: Error at offset 0 of 6 bytes in /home/arborrow/Moodle/code/19stable/backup/lib.php on line 534

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Yup, this is in my TODO list since some weeks ago.

it's caused by wrongly inserted data (without serialise) in the backups_ids table.I'm planning to change that place to serialize before insert.

Anyway, I've done it quickly because it doesn't cause any error (by the notice), I checked that 100% and it's one part of backup that, perhaps, could be skipped.

Solution will arrive soon, for sure.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Yup, this is in my TODO list since some weeks ago. it's caused by wrongly inserted data (without serialise) in the backups_ids table.I'm planning to change that place to serialize before insert. Anyway, I've done it quickly because it doesn't cause any error (by the notice), I checked that 100% and it's one part of backup that, perhaps, could be skipped. Solution will arrive soon, for sure. Ciao
Hide
Sam Marshall added a comment -

Is there any progress on this?

Show
Sam Marshall added a comment - Is there any progress on this?
Hide
Eloy Lafuente (stronk7) added a comment -

Sorry, nothing yet. I'm trying to finish blog backup & restore and will be back to user/roles backup tests soon. Thanks for pinging!

Show
Eloy Lafuente (stronk7) added a comment - Sorry, nothing yet. I'm trying to finish blog backup & restore and will be back to user/roles backup tests soon. Thanks for pinging!
Hide
Peter Poznyakov added a comment -

I have the same problem. Everything went well. But it appears without any visible reason.

Show
Peter Poznyakov added a comment - I have the same problem. Everything went well. But it appears without any visible reason.
Hide
Eloy Lafuente (stronk7) added a comment -

Oki,

so we need to:

1) Serialize properly when writing user->info
2) Check all current unserialized uses of 'needed' and "needed" and make them unserialize user->info properly.

Assigning this to David after chat, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Oki, so we need to: 1) Serialize properly when writing user->info 2) Check all current unserialized uses of 'needed' and "needed" and make them unserialize user->info properly. Assigning this to David after chat, thanks!
Hide
David Mudrak added a comment -

Eloy, are we going to fix this actually? I would close it with "Won't fix" status...

Show
David Mudrak added a comment - Eloy, are we going to fix this actually? I would close it with "Won't fix" status...
Hide
David Mudrak added a comment -

Postponing again - needs Eloy's decision and re-triaging.

Show
David Mudrak added a comment - Postponing again - needs Eloy's decision and re-triaging.

People

Dates

  • Created:
    Updated: