Helen Foster - 25/Feb/08 06:05 PM Suggested reworded README: This theme contains graphics for customising corners and borders. It makes use of a technique described by Roger Johansson - see http://www.456bereastreet.com/archive/200506/customising_custom_corners_and_borders/ However, the custom corners theme doesn't use all the JavaScript mentioned by Roger Johansson. Instead, divs are added when "$THEME->customcorners = true;" is set in config.php. Note: Custom corners is included in Moodle 1.9 as an experimental feature. Additional information: Custom corners uses the Chameleon theme engine. Hooks should NOT be written as comma separated lists of elements, for example td#middle-column div.bt, div#middle-column div.bt {     ... } Instead two separate statements should be used, for example td#middle-column div.bt {     ... } div#middle-column div.bt {     ... } Custom corners was created by Urs Hunkler http://www.unodo.de/.

Helen Foster - 25/Feb/08 06:08 PM To be fixed in 1.9. Any comments from watchers would be appreciated.

Helen Foster - 25/Feb/08 06:12 PM A further suggestion would be to shorten then README text by including some of the information in a documentation page about the custom corners theme, and then including a link to the documentation page in the README text.

Matt Gibson - 25/Feb/08 07:54 PM Hi Helen, 'Experimental' is a good word, but will probably put people off using it as it implies 'broken', at least to me. It would be good to explain that it can be used as a parent theme for creating your own custom themes, as I've done. Not sure if there is a documentation page for this or not.

Helen Foster - 25/Feb/08 08:57 PM Hi Matt, Thanks for your comment. There is now a custom corners theme page in the documentation - http://docs.moodle.org/en/Custom_corners_theme - for explanation of how the theme can be used etc.

Urs Hunkler - 25/Feb/08 11:01 PM Hi Helen, I will change the README as you suggested, except the note about being experimental. Why do you propose to call custom_corners "experimental". I always expected it to be a normal Moodle 1.9 theme. Do you see any issues with this theme? It would be a pity if that is the case. We all have been intensively working to get it ready for a long time now.

Martin Dougiamas - 25/Feb/08 11:05 PM I think the issue is that it's not quite ready and we're out of time for 1.9 ... this theme has required a lot of changes to core Moodle already...

Urs Hunkler - 25/Feb/08 11:17 PM Hi Martin, what issues do you know concerning custom_corners?

Martin Dougiamas - 26/Feb/08 06:29 PM I thought there were still a number of issues that were open related to this theme, or are the JS CSS hacks (which I still worry about) manage to workaround all those problems? I've been having all sorts of troubles with my theme on partners.moodle.com because it uses this as a parent and whenever your header.html changes my theme was breaking. So it's not like a "normal" theme in that respect.

Martin Dougiamas - 27/Feb/08 02:42 PM It also doesn't inherit anything from "standard" so everytime we add colours to the interface to improve usability we have to do it again for custom_corners. Of course, lots of developers forget to treat custom_corners as an exception to the rule so custom_corners ends up missing usability. I've been fixing a some of these lately (eg MDL-12248 and MDL-13685) but it's a bit annoying.

Urs Hunkler - 27/Feb/08 07:55 PM several enhancements/changes due to the discussion in the Moodle tracker: _ changed the README - Custom corners is now experimental _ styles_colors from standard included - all the usabilty work using colors will automatically show up in Custom corners too _ optimized the JavaScript which adds the necessary layouttable classes to the body tag _ Chameleon engine removed - developers throw in CSS at the end without caring if the Chameleon engine can handle it It's great that Custom corners gets so much attention in the moment. To test the last changes over a longer time before 1.9 is released is not possible - so the theme is declared experimental as Helen/Martin propose. About taking out the Chameleon engine I had been thinking for some time already. When I saw the CSS Martin had thrown in at the end of the CSS I saw that the Chameleon engine will never be able to work correctly. Taking it out is the right consequence. The theme is too complex and too dynamic with hand added CSS. The Moodle usability enhancements with colors in the last time is marvelous. To reflect the changes in Custom corners I included styles_color from standard. Font handling is too different. Important changes need to be added by hand. By the way, Martin. Why do you add .plugincompattable twice with each defining one CSS property instead of using one with the two property definitions? A little care might be helpful - even when it is only a theme :-(

Martin Dougiamas - 28/Feb/08 12:46 PM I had to cut and paste them there from two different files in standard and didn't notice the repetition. I see it's fixed now, thanks.