Moodle

Manually adding/deleting a related tag should add/delete a reverse related tag too

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Tags
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

ie if I add "B" to tag "A", then "B" should have "A" added to it too (and same for deleting).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mathieu Petit-Clair added a comment -

This should now be working.

Show
Mathieu Petit-Clair added a comment - This should now be working.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Working here. Closing. Thanks!

Offtopic: when viewing code I take a look to tag_compute_correlations() ... is it really calculating what we want? Not tested but always I look to that query I have doubts...

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Working here. Closing. Thanks! Offtopic: when viewing code I take a look to tag_compute_correlations() ... is it really calculating what we want? Not tested but always I look to that query I have doubts... Ciao
Hide
Permalink
Mathieu Petit-Clair added a comment -

Thanks for verifying this one, it wasn't so trivial after all.

About the query, all I can say is that I tested it out quite a lot in phpmyadmin and the results looked right. But this wasn't working before - the "min_correlations parameter" was too low (actually, I think you found that out) - and now it's too late to change the database structure to make this more efficient (I tend to really dislike comma-separated fields in something that should be a relational database...).

Show
Mathieu Petit-Clair added a comment - Thanks for verifying this one, it wasn't so trivial after all. About the query, all I can say is that I tested it out quite a lot in phpmyadmin and the results looked right. But this wasn't working before - the "min_correlations parameter" was too low (actually, I think you found that out) - and now it's too late to change the database structure to make this more efficient (I tend to really dislike comma-separated fields in something that should be a relational database...).

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.