[#MDL-13726] Latest commits to Ko_utf8 not XHTML compliant.

Moodle

Latest commits to Ko_utf8 not XHTML compliant.

Created: 29/Feb/08 03:37 PM Updated: 15/Oct/08 03:00 PM

Component/s:

Languages

Affects Version/s:

1.9

Fix Version/s:

1.9.4

Issue Links:

Duplicate

This issue is duplicated by:

MDL-13974 Undesirable HTML tags in language strings

Participants:	Dan Marsden, David Mudrak, Koen Roggemans, Nicolas Martignoni and Petr Škoda
Security Level:	None

Description

« Hide

Just noticed in the last couple of commits for the ko_utf8 lang pack that it is not XHTML compliant

seem to be lots of <b></b> tags - should be <strong></strong>

might need to educate the maintainers regarding XHTML

eg the following are no longer valid
<b>
<i>
<u>
<br> - should be <br />
etc etc......

:-)

Dan

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Petr Škoda - 04/Mar/08 05:53 AM

grep reveals more of these, please search & replace all of them ;-)

[ Permlink | « Hide ]

Koen Roggemans - 04/Mar/08 06:09 AM

Only a few thousands ...I'll do a forum post, and correct as much as possible
In 1.5 they were 100% fixed :-(

[ Permlink | « Hide ]

Koen Roggemans - 07/Mar/08 06:08 AM

Following http://www.webreference.com/xml/reference/xhtml.html and http://www.w3schools.com/tags/default.asp it looks like <b> and <i> are no problem to use..
<u> is depreciated ...

[ Permlink | « Hide ]

Dan Marsden - 07/Mar/08 07:11 AM

wow! - I stand corrected! - I was sure that <b></b> didn't validate using the w3c Validator... I'm wrong - thanks Koen!

I wonder if this is something we need to move towards as a Moodle coding guideline? - as in which tag should be used when making text bold?

:-)

DAn

[ Permlink | « Hide ]

Nicolas Martignoni - 07/Mar/08 04:55 PM

Koen,

What do you intend to do with the underlined text example in file "help/text.html"?

[ Permlink | « Hide ]

Nicolas Martignoni - 07/Mar/08 05:02 PM

And do we have a recommendation for removing the remaining <font ...> tags in the lang packs?

Could be useful to define CSS rules in standard theme for the cases where such a style is lacking.

[ Permlink | « Hide ]

Koen Roggemans - 07/Mar/08 06:01 PM

You're right Nicolas: we need some more stuff in standard CSS to deal with the <u> and the remaining <font> tags, may be some other things to.
First thing to do is get the English language pack 100% OK as a reference. Are there any quick tools available to scan them for problems? Otherwise it's grepping for depreciated elements...

[ Permlink | « Hide ]

Nicolas Martignoni - 07/Mar/08 06:22 PM

I'm not aware of such tools. I'm using myself brute grepping ;-)

[ Permlink | « Hide ]

David Mudrak - 08/Mar/08 08:08 PM

I found the following script useful when looking for problematic parts of the Czech help files. It just concatenates all HTML help files into one big file, which can be then processed by a validating tool (Firefox plugin "HTML validator" in my case).

#!/bin/bash

OUTPUT=~/tmp/allhelp.html

echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="cs" xml:lang="cs">
<head>
<title>Moodle Help Files</title>
<style type="text/css">.filename { background-color: #ddd; color: red; }</style>
</head>
<body>' > $OUTPUT

find . -name "*.html" -printf "<div class=\"filename\">" -print -printf "</div>\n" -exec cat '{}' \; >> $OUTPUT

echo '</body></html>' >> $OUTPUT