Moodle

Latest commits to Ko_utf8 not XHTML compliant.

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: STABLE backlog
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Just noticed in the last couple of commits for the ko_utf8 lang pack that it is not XHTML compliant

seem to be lots of <b></b> tags - should be <strong></strong>

might need to educate the maintainers regarding XHTML

eg the following are no longer valid
<b>
<i>
<u>
<br> - should be <br />
etc etc......

Dan

Issue Links

This issue is duplicated by:
MDL-13974 Undesirable HTML tags in language strings Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

grep reveals more of these, please search & replace all of them

Show
Petr Škoda (skodak) added a comment - grep reveals more of these, please search & replace all of them
Hide
Permalink
Koen Roggemans added a comment -

Only a few thousands ...I'll do a forum post, and correct as much as possible
In 1.5 they were 100% fixed

Show
Koen Roggemans added a comment - Only a few thousands ...I'll do a forum post, and correct as much as possible In 1.5 they were 100% fixed
Hide
Permalink
Koen Roggemans added a comment -

Following http://www.webreference.com/xml/reference/xhtml.html and http://www.w3schools.com/tags/default.asp it looks like <b> and <i> are no problem to use..
<u> is depreciated ...

Show
Koen Roggemans added a comment - Following http://www.webreference.com/xml/reference/xhtml.html and http://www.w3schools.com/tags/default.asp it looks like <b> and <i> are no problem to use.. <u> is depreciated ...
Hide
Permalink
Dan Marsden added a comment -

wow! - I stand corrected! - I was sure that <b></b> didn't validate using the w3c Validator... I'm wrong - thanks Koen!

I wonder if this is something we need to move towards as a Moodle coding guideline? - as in which tag should be used when making text bold?

DAn

Show
Dan Marsden added a comment - wow! - I stand corrected! - I was sure that <b></b> didn't validate using the w3c Validator... I'm wrong - thanks Koen! I wonder if this is something we need to move towards as a Moodle coding guideline? - as in which tag should be used when making text bold? DAn
Hide
Permalink
Nicolas Martignoni added a comment -

Koen,

What do you intend to do with the underlined text example in file "help/text.html"?

Show
Nicolas Martignoni added a comment - Koen, What do you intend to do with the underlined text example in file "help/text.html"?
Hide
Permalink
Nicolas Martignoni added a comment -

And do we have a recommendation for removing the remaining <font ...> tags in the lang packs?

Could be useful to define CSS rules in standard theme for the cases where such a style is lacking.

Show
Nicolas Martignoni added a comment - And do we have a recommendation for removing the remaining <font ...> tags in the lang packs? Could be useful to define CSS rules in standard theme for the cases where such a style is lacking.
Hide
Permalink
Koen Roggemans added a comment -

You're right Nicolas: we need some more stuff in standard CSS to deal with the <u> and the remaining <font> tags, may be some other things to.
First thing to do is get the English language pack 100% OK as a reference. Are there any quick tools available to scan them for problems? Otherwise it's grepping for depreciated elements...

Show
Koen Roggemans added a comment - You're right Nicolas: we need some more stuff in standard CSS to deal with the <u> and the remaining <font> tags, may be some other things to. First thing to do is get the English language pack 100% OK as a reference. Are there any quick tools available to scan them for problems? Otherwise it's grepping for depreciated elements...
Hide
Permalink
Nicolas Martignoni added a comment -

I'm not aware of such tools. I'm using myself brute grepping

Show
Nicolas Martignoni added a comment - I'm not aware of such tools. I'm using myself brute grepping
Hide
Permalink
David Mudrak added a comment -

I found the following script useful when looking for problematic parts of the Czech help files. It just concatenates all HTML help files into one big file, which can be then processed by a validating tool (Firefox plugin "HTML validator" in my case).

#!/bin/bash

OUTPUT=~/tmp/allhelp.html

echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="cs" xml:lang="cs">
<head>
<title>Moodle Help Files</title>
<style type="text/css">.filename { background-color: #ddd; color: red; }</style>
</head>
<body>' > $OUTPUT

find . -name "*.html" -printf "<div class=\"filename\">" -print -printf "</div>\n" -exec cat '{}' \; >> $OUTPUT

echo '</body></html>' >> $OUTPUT

Show
David Mudrak added a comment - I found the following script useful when looking for problematic parts of the Czech help files. It just concatenates all HTML help files into one big file, which can be then processed by a validating tool (Firefox plugin "HTML validator" in my case). #!/bin/bash OUTPUT=~/tmp/allhelp.html echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="cs" xml:lang="cs"> <head> <title>Moodle Help Files</title> <style type="text/css">.filename { background-color: #ddd; color: red; }</style> </head> <body>' > $OUTPUT find . -name "*.html" -printf "<div class=\"filename\">" -print -printf "</div>\n" -exec cat '{}' \; >> $OUTPUT echo '</body></html>' >> $OUTPUT
Hide
Permalink
Koen Roggemans added a comment -

According to the guide lines from David (concatenating the help files, running it through a validator) I came up with this rapport of HTML errors in the English help files.
I let the validator only check for HTML errors, not accessibility. It brings up an amazing 1100 errors.

Show
Koen Roggemans added a comment - According to the guide lines from David (concatenating the help files, running it through a validator) I came up with this rapport of HTML errors in the English help files. I let the validator only check for HTML errors, not accessibility. It brings up an amazing 1100 errors.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.