Moodle

Site-wide option for aggregation of scales

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

I use a common scaled called "Not Submitted/Submitted". Through 1.8 this was not factored into the grade. On import, these were factored in, apparently worth 1 or 2 points each. When I removed these from the 1.9 import, grades changed, they should not have.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending a patch that removes scales from simple means aggregation - this could solve the backwards compatibility issues

Show
Petr Škoda (skodak) added a comment - sending a patch that removes scales from simple means aggregation - this could solve the backwards compatibility issues
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending patch with site setting for aggregation of scales

Show
Petr Škoda (skodak) added a comment - sending patch with site setting for aggregation of scales
Hide
Permalink
Martin Dougiamas added a comment -

Petr, why is sum of grades an exception? I think it should be consistent otherwise it's far too confusing for end-users.

Show
Martin Dougiamas added a comment - Petr, why is sum of grades an exception? I think it should be consistent otherwise it's far too confusing for end-users.
Hide
Permalink
Martin Dougiamas added a comment -

Otherwise OK. Can probably just be

empty($CFG->grade_includescalesinaggregation)

the isset is redundant I think.

Show
Martin Dougiamas added a comment - Otherwise OK. Can probably just be empty($CFG->grade_includescalesinaggregation) the isset is redundant I think.
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

the sum was skipping the scales/outcomes since it was added, there are some unset()s which do that during aggregation, should it be changed? It would not be enough to undo it in depends_on().

the isset() is there to prevent calculation problems because the default 1 is applied after upgrade which I could not do because the version number is already moved to 09.00

Show
Petr Škoda (skodak) added a comment - - edited the sum was skipping the scales/outcomes since it was added, there are some unset()s which do that during aggregation, should it be changed? It would not be enough to undo it in depends_on(). the isset() is there to prevent calculation problems because the default 1 is applied after upgrade which I could not do because the version number is already moved to 09.00
Hide
Permalink
Martin Dougiamas added a comment -

Yeah I think it definitely should be completely consistent. So admins can tell users: "scales are all skipped" or not.

We can go from version 09 -> 19 to be nice I think, but we have to be sure it's the last one!!!!

Show
Martin Dougiamas added a comment - Yeah I think it definitely should be completely consistent. So admins can tell users: "scales are all skipped" or not. We can go from version 09 -> 19 to be nice I think, but we have to be sure it's the last one!!!!
Hide
Permalink
Petr Škoda (skodak) added a comment -

The problem with scales are:

  • result of sum is always number - it can not be scale because the max is computed
  • what is the "point" value of scale value? is it grademax or grademax-1
Show
Petr Škoda (skodak) added a comment - The problem with scales are:
  • result of sum is always number - it can not be scale because the max is computed
  • what is the "point" value of scale value? is it grademax or grademax-1
Hide
Permalink
Martin Dougiamas added a comment -

Actually, just include it in the upgrade to 09 thanks that makes more sense.

empty() doesn't give errors when the variable doesn't exist anyway.

Show
Martin Dougiamas added a comment - Actually, just include it in the upgrade to 09 thanks that makes more sense. empty() doesn't give errors when the variable doesn't exist anyway.
Hide
Permalink
Petr Škoda (skodak) added a comment -

patch with scale support in sums

Show
Petr Škoda (skodak) added a comment - patch with scale support in sums
Hide
Permalink
Petr Škoda (skodak) added a comment -

I agree it makes sense to sum the star scales

Show
Petr Škoda (skodak) added a comment - I agree it makes sense to sum the star scales
Hide
Permalink
Petr Škoda (skodak) added a comment -

patch committed into cvs - the aggregation of scales is now configurable at site level

thanks everybody

Show
Petr Škoda (skodak) added a comment - patch committed into cvs - the aggregation of scales is now configurable at site level thanks everybody
Hide
Permalink
Courtney Bentley added a comment -

what is the thought on having this be configurable on the site level instead of on the individual course level? i have some faculty who would love to allow their "checks" scale to figure into the calculation but others who will be upset that the scale that was once just text will not figure in to final grades. – who should win this battle since i have to set it on the site level?

another suggestion would be to provide a user interface to allow the scales to have specific values associated.

Show
Courtney Bentley added a comment - what is the thought on having this be configurable on the site level instead of on the individual course level? i have some faculty who would love to allow their "checks" scale to figure into the calculation but others who will be upset that the scale that was once just text will not figure in to final grades. – who should win this battle since i have to set it on the site level? another suggestion would be to provide a user interface to allow the scales to have specific values associated.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.