Issue Details (XML | Word | Printable)

Key: MDL-13792
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Mathieu Petit-Clair
Reporter: Bill Burgos
Votes: 1
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

File uploads created with Japanese file names in Japanese Windows and IE cannot be downloaded.

Created: 05/Mar/08 08:20 AM   Updated: 28/May/08 01:19 PM
Return to search
Component/s: Unicode
Affects Version/s: 1.8.4
Fix Version/s: 1.8.6, 1.9.1

File Attachments: 1. Text File patch-jp-urlencode.1.txt (2 kB)
2. Text File patch-urlencode-skodak_18.txt (6 kB)
3. Text File urlencoding_skodak.patch (6 kB)
Environment:
User side: Japanese Windows, IE 6
Server LAMP

Database: MySQL
Participants: Bill Burgos, Dongsheng Cai, Larry M Elchuck, Ph.D., Martin Dougiamas, Mathieu Petit-Clair and Petr Skoda
Security Level: None
QA Assignee: Dongsheng Cai
Resolved date: 17/Apr/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
1. Upload a file to, say, an assignment using a Japanese filename or upload to Folder.

2. Retrieve the file by clicking on the link.

3. Moodle reports an error that the file cannot be found.

This only seems to occur with Japanese Windows and IE. Using English Windows does not reproduce this problem. May be a coding issue.

There exists a proposed fix:

http://docs.moodle.org/ja/%E3%82%B5%E3%82%A4%E3%83%88%E3%83%95%E3%82%A1%E3%82%A4%E3%83%AB

Perhaps this can get into code?

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Mathieu Petit-Clair committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 27/Mar/08 10:48 AM
MDL-13792 - Use urlencode for filename in upload and uploadsingle assignments to fix problems with multibytes filenames.
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.30.2.3    (+3 -3 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.29.2.5    (+4 -4 lines)
Mathieu Petit-Clair committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 01/Apr/08 09:55 AM
MDL-13792 - Fix to prevent urlencoding of '/'
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.29.2.6    (+4 -4 lines)
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.30.2.4    (+3 -3 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/Apr/08 04:24 AM
MDL-13792 reverting previous commits - the use of urlencode() is not correct
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.30.2.5    (+3 -3 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.29.2.7    (+4 -4 lines)
Mathieu Petit-Clair committed 4 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 08/Apr/08 11:00 AM
MDL-13792 - Commiting Patch by Skodak, fixing problem with japanese characters under some conditions. This has been reported to work, if nobody else
comes foward with bugs related to this, it will need to be changed everywhere else where there is no urlencoding done at this time.
MODIFY mod/assignment/lib.php   Rev. 1.219.2.25    (+3 -7 lines)
MODIFY lib/filelib.php   Rev. 1.39.2.11    (+35 -1 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.29.2.8    (+5 -8 lines)
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.30.2.6    (+4 -9 lines)
Mathieu Petit-Clair committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 08/Apr/08 11:02 AM
MDL-13792 - Commiting Patch by Skodak, fixing problem with japanese characters under some conditions. This has been reported to work, if nobody else
comes foward with bugs related to this, it will need to be changed everywhere else where there is no urlencoding done at this time. (1.9 - original
patch)
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.33.2.5    (+3 -8 lines)
MODIFY mod/assignment/lib.php   Rev. 1.277.2.41    (+2 -7 lines)
MODIFY lib/filelib.php   Rev. 1.50.2.12    (+35 -1 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.32.2.13    (+5 -7 lines)
Mathieu Petit-Clair committed 4 files to 'Moodle CVS' - 08/Apr/08 11:04 AM
MDL-13792 - Commiting Patch by Skodak, fixing problem with japanese characters under some conditions. This has been reported to work, if nobody else
comes foward with bugs related to this, it will need to be changed everywhere else where there is no urlencoding done at this time. (merge from 1.8
and 1.9)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.46    (+5 -7 lines)
MODIFY mod/assignment/lib.php   Rev. 1.320    (+2 -7 lines)
MODIFY lib/filelib.php   Rev. 1.63    (+35 -1 lines)
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.38    (+3 -8 lines)
Mathieu Petit-Clair committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/May/08 01:15 PM
MDL-13792: fixing problem in the previous patch, where filename contain spaces
MODIFY lib/filelib.php   Rev. 1.50.2.14    (+3 -3 lines)
Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 28/May/08 01:17 PM
MDL-13792: fixing problem in the previous patch, where filename contain spaces (merge from 1.9)
MODIFY lib/filelib.php   Rev. 1.67    (+3 -3 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators