[#MDL-13793] Wiki module doesn't work under mysqli

Issue Details (XML | Word | Printable)

Key:	MDL-13793
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Critical
Assignee:	Eloy Lafuente (stronk7)
Reporter:	Eloy Lafuente (stronk7)
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Wiki module doesn't work under mysqli

Created: 05/Mar/08 08:33 AM Updated: 15/Apr/08 04:49 PM

Return to search

Component/s:

Wiki (1.x)

Affects Version/s:

1.8.4, 1.9

Fix Version/s:

1.8.5, 1.9.1

Database:	MySQL
Participants:	Eloy Lafuente (stronk7) and Petr Skoda
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	05/Mar/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE

Description

« Hide

It seems that current (e)wiki module doesn't work at all. All I get under 19_STABLE is a blank page after creating the activity.

Using MySQL(i) DB driver.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 05/Mar/08 08:36 AM

Tracing down the problem (nothing is showed in error logs) it seems that, in the anydb_escape_string() function (mod/wiki/ewikimoodlelib.php) we are using the mysql_escape_string() function boht under mysqli and mysql drivers.

Going to change that function to ALWAYS (any DB) return the results of a simple addslashes() really I cannot imagine any reason against that.

Ciao

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 05/Mar/08 08:43 AM

Done. Applied to 18_STABLE, 19_STABLE and HEAD. Works under mysqli perfectly (and should against the rest).

Closing, ciao

[ Permalink | « Hide ]

Petr Skoda added a comment - 15/Apr/08 04:48 PM

reviewed patch, closing -thanks!

All content on this web site is made available under the GNU General Public License, unless otherwise stated.