Moodle

Arrow heads in breadcrumbs not showing correctly in themes bundled with Moodle

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: STABLE backlog
  • Component/s: Themes
  • Labels:
    None
  • Environment:
    IE 6
  • Affected Branches:
    MOODLE_19_STABLE

Description

The arrowheads weren't showing in IE 6 using Formal white (nav bar and calendar). Andrea Bicciolo quickly fixed the font issue so the arrows show now but they show without a space before them (see attached image).

Thought I'd check all themes and results where:

  • Orange white (and the PDA version) has the font issue - arrows don' show
  • Custom corners is fine
  • All other bundled themes show the arrows but without spaces in front of the arrows

Initial forum post: http://moodle.org/mod/forum/discuss.php?d=91942

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Gibson added a comment -

I recently re-created the moodle.org stars rating scale for my students to use and many said that the stars don't display properly at home - they come up as squares just like the orangewhite example above. Is this a related problem?

Show
Matt Gibson added a comment - I recently re-created the moodle.org stars rating scale for my students to use and many said that the stars don't display properly at home - they come up as squares just like the orangewhite example above. Is this a related problem?
Hide
Permalink
Harry Smith added a comment -

Somewhere along the lines the font issue seems to have crept back in. Not sure when (try to avoid using IE!) but noticed today the arrows where back to boxes, checked fw_fonts.css and sure enough, Verdana was back in? (Moodle 1.9+, Build 20080428). After deleting Verdana and Geneva from the CSS, arrows back but still with no space before them.

Show
Harry Smith added a comment - Somewhere along the lines the font issue seems to have crept back in. Not sure when (try to avoid using IE!) but noticed today the arrows where back to boxes, checked fw_fonts.css and sure enough, Verdana was back in? (Moodle 1.9+, Build 20080428). After deleting Verdana and Geneva from the CSS, arrows back but still with no space before them.
Hide
Permalink
Ann Adamcik added a comment -

For the spacing issue, there are regular spaces inserted before and after the separator, so the generated code for a list item looks like this:

<li class="first"> <span class="accesshide " >/ </span><span class="arrow sep">►</span> Administration</li>

Firefox renders both spaces, but IE(6&7) collapses that first space. Using non-breaking spaces instead will render the same in both browsers. Here's a patch -

Index: weblib.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lib/weblib.php,v
retrieving revision 1.970.2.80
diff -c -r1.970.2.80 weblib.php

      • weblib.php 29 Apr 2008 05:07:57 -0000 1.970.2.80
      • weblib.php 7 May 2008 10:34:55 -0000
        ***************
      • 3546,3552 ****
        */
        function get_separator() { //Accessibility: the 'hidden' slash is preferred for screen readers. ! return ' '.link_arrow_right($text='/', $url='', $accesshide=true, 'sep').' '; }

/**
— 3546,3552 ----
*/
function get_separator() { //Accessibility: the 'hidden' slash is preferred for screen readers. ! return ' '.link_arrow_right($text='/', $url='', $accesshide=true, 'sep').' '; }

/**

Show
Ann Adamcik added a comment - For the spacing issue, there are regular spaces inserted before and after the separator, so the generated code for a list item looks like this: <li class="first"> <span class="accesshide " >/ </span><span class="arrow sep">►</span> Administration</li> Firefox renders both spaces, but IE(6&7) collapses that first space. Using non-breaking spaces instead will render the same in both browsers. Here's a patch - Index: weblib.php =================================================================== RCS file: /cvsroot/moodle/moodle/lib/weblib.php,v retrieving revision 1.970.2.80 diff -c -r1.970.2.80 weblib.php
      • weblib.php 29 Apr 2008 05:07:57 -0000 1.970.2.80
      • weblib.php 7 May 2008 10:34:55 -0000 ***************
      • 3546,3552 **** */ function get_separator() { //Accessibility: the 'hidden' slash is preferred for screen readers. ! return ' '.link_arrow_right($text='/', $url='', $accesshide=true, 'sep').' '; }
/** — 3546,3552 ---- */ function get_separator() { //Accessibility: the 'hidden' slash is preferred for screen readers. ! return ' '.link_arrow_right($text='/', $url='', $accesshide=true, 'sep').' '; } /**

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.