Issue Details (XML | Word | Printable)

Key: MDL-13859
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Rossiani Wijaya
Reporter: Johannes Albert
Votes: 3
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

AJAX for dropping boxes onto the right column is broken (fix inside)

Created: 10/Mar/08 01:35 PM   Updated: 21/Oct/09 04:17 PM
Return to search
Component/s: AJAX, Blocks
Affects Version/s: 1.9
Fix Version/s: 1.9.7

Environment: WinXPSP2, FF 2.0.0.12, IE6SP2

Participants: Eloy Lafuente (stronk7), Johannes Albert, Martin Dougiamas, Paolo Oprandi and Rossiani Wijaya
Security Level: None
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Dragging and Dropping Blocks onto the right column doesn't work. The Block sticks to the cursor and you can only get rid of it by clicking into the left column.
Firebug gives the following Error: "Node was not found" code: "8"

Solution:
In moodle/lib/ajax/block_classes.js#175

    column.getEl().insertBefore(this.getEl(),main.adminBlock);

should be

    column.getEl().insertBefore(this.getEl(),main.adminBlock.parentNode);


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 14/Apr/08 08:59 AM
Thanks for the info, Johannes. Assigning to Nicolas and addressing to 1.9.1...ciao

Paolo Oprandi added a comment - 01/Jun/09 11:26 PM
Nice fix!
Seems so important to me it should go straight into Moodle 1.95

Martin Dougiamas added a comment - 01/Oct/09 06:08 PM
Another one for you Rossiani! Can you check this out?

Rossiani Wijaya added a comment - 13/Oct/09 01:28 PM
Changing main.adminBlock to main.adminBlock.parentNode does fix the issue. However, it would allow the moving block to be added above the pinned block. The position of the moving block may not display properly when the editing page is turn off.

Please refer to MDL-11131 for available patch.

Thanks
Rosie