Moodle

AJAX for dropping boxes onto the right column is broken (fix inside)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.10
  • Component/s: AJAX, Blocks
  • Labels:
    None
  • Environment:
    WinXPSP2, FF 2.0.0.12, IE6SP2
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Dragging and Dropping Blocks onto the right column doesn't work. The Block sticks to the cursor and you can only get rid of it by clicking into the left column.
Firebug gives the following Error: "Node was not found" code: "8"

Solution:
In moodle/lib/ajax/block_classes.js#175

column.getEl().insertBefore(this.getEl(),main.adminBlock);

should be

column.getEl().insertBefore(this.getEl(),main.adminBlock.parentNode);

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Thanks for the info, Johannes. Assigning to Nicolas and addressing to 1.9.1...ciao

Show
Eloy Lafuente (stronk7) added a comment - Thanks for the info, Johannes. Assigning to Nicolas and addressing to 1.9.1...ciao
Hide
Paolo Oprandi added a comment -

Nice fix!
Seems so important to me it should go straight into Moodle 1.95

Show
Paolo Oprandi added a comment - Nice fix! Seems so important to me it should go straight into Moodle 1.95
Hide
Martin Dougiamas added a comment -

Another one for you Rossiani! Can you check this out?

Show
Martin Dougiamas added a comment - Another one for you Rossiani! Can you check this out?
Hide
Rossiani Wijaya added a comment -

Changing main.adminBlock to main.adminBlock.parentNode does fix the issue. However, it would allow the moving block to be added above the pinned block. The position of the moving block may not display properly when the editing page is turn off.

Please refer to MDL-11131 for available patch.

Thanks
Rosie

Show
Rossiani Wijaya added a comment - Changing main.adminBlock to main.adminBlock.parentNode does fix the issue. However, it would allow the moving block to be added above the pinned block. The position of the moving block may not display properly when the editing page is turn off. Please refer to MDL-11131 for available patch. Thanks Rosie
Hide
Rossiani Wijaya added a comment -

Please take a look MDL-11131 for patches or upgrade to the latest version of moodle.
please feel free to create new tracker if there is any issue with the course sticky blocks.

Thanks.
Rosie

Resolved.

Show
Rossiani Wijaya added a comment - Please take a look MDL-11131 for patches or upgrade to the latest version of moodle. please feel free to create new tracker if there is any issue with the course sticky blocks. Thanks. Rosie Resolved.

Dates

  • Created:
    Updated:
    Resolved: