[#MDL-13866] scale ratings do not work in forum

Issue Details (XML | Word | Printable)

Key:	MDL-13866
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Blocker
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

scale ratings do not work in forum

Created: 10/Mar/08 07:39 PM Updated: 02/Apr/08 03:37 AM

Return to search

Component/s:

Forum

Affects Version/s:

1.9

Fix Version/s:

1.9.1

Issue Links:

Dependency

This issue will help resolve:

~~MDL-13804~~ forum sum ratings are broken/ counterintuitive for star scales

Participants:	Eloy Lafuente (stronk7), Matt Gibson and Petr Skoda
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	10/Mar/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

// it could throw off the grading if count and sum returned a rawgrade higher than scale
// so to prevent it we review the results and ensure that rawgrade does not exceed the scale, if it does we set rawgrade = scale (i.e. full credit)

the trouble is that forum->scale is NEGATIVE in case of scale ratings

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Mar/08 07:40 PM

~~MDL-13866~~ scale ratings do not work in forum

MODIFY

mod/forum/lib.php

Rev. 1.609.2.35

(+13 -4 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 10/Mar/08 07:41 PM

~~MDL-13866~~ scale ratings do not work in forum; merged from MOODLE_19_STABLE

MODIFY

mod/forum/lib.php

Rev. 1.644

(+13 -4 lines)

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Mar/08 07:45 PM

~~MDL-13866~~ scale ratings do not work in forum; merged from MOODLE_19_STABLE

MODIFY	mod/forum/db/upgrade.php		Rev. 1.5.2.1		(+9 -9 lines)
MODIFY	mod/forum/version.php		Rev. 1.69.2.2		(+2 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 10/Mar/08 07:46 PM

~~MDL-13866~~ scale ratings do not work in forum; merged from MOODLE_19_STABLE

MODIFY	mod/forum/version.php		Rev. 1.71		(+2 -2 lines)
MODIFY	mod/forum/db/upgrade.php		Rev. 1.6		(+9 -9 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Mar/08 07:47 PM

should be fixed now - please reopen in case of any problems

Petr Skoda made changes - 10/Mar/08 07:47 PM

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Mar/08 08:17 PM

Reported by Kathrin Lind

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/08 06:16 AM

~~MDL-13866~~ fixed stupid bug in my last commit

MODIFY	mod/forum/lib.php		Rev. 1.609.2.36		(+7 -4 lines)
MODIFY	mod/forum/lib.php		Rev. 1.609.2.37		(+2 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 11/Mar/08 06:18 AM

~~MDL-13866~~ fixed stupid bug in my last commit; merged from MOODLE_19_STABLE

MODIFY

mod/forum/lib.php

Rev. 1.645

(+8 -5 lines)

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/08 06:18 AM

~~MDL-13866~~ scale ratings do not work in forum

MODIFY	mod/forum/db/upgrade.php		Rev. 1.5.2.2		(+2 -2 lines)
MODIFY	mod/forum/version.php		Rev. 1.69.2.3		(+2 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 11/Mar/08 06:19 AM

~~MDL-13866~~ scale ratings do not work in forum; merged from MOODLE_19_STABLE

MODIFY	mod/forum/db/upgrade.php		Rev. 1.7		(+2 -2 lines)
MODIFY	mod/forum/version.php		Rev. 1.72		(+2 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 16/Mar/08 07:50 AM

~~MDL-13866~~ adding warning that regrading of forums may take a while

MODIFY

mod/forum/db/upgrade.php

Rev. 1.5.2.3

(+2 -1 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 16/Mar/08 07:51 AM

~~MDL-13866~~ adding warning that regrading of forums may take a while; merged from MOODLE_19_STABLE

MODIFY

mod/forum/db/upgrade.php

Rev. 1.8

(+2 -1 lines)

Matt Gibson made changes - 25/Mar/08 03:13 AM

Link

This issue will help resolve ~~MDL-13804~~ [ ~~MDL-13804~~ ]

[ Permalink | « Hide ]

Matt Gibson added a comment - 25/Mar/08 03:13 AM

Hi Petr,

I'm using summed scales and have created a 5-star scale a bit like moodle.org's. I want to say to the students "you must get 10 stars to pass", but the gradebook only goes up to 5. Further discussion on the linked issue.

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 02/Apr/08 02:03 AM

Seems to be working now... long process, hehe. Closing...ciao

Eloy Lafuente (stronk7) made changes - 02/Apr/08 02:03 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee		stronk7

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Apr/08 03:37 AM

Hi Matt, this is a known problem - Anthony might be already working on that.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.