Issue Details (XML | Word | Printable)

Key: MDL-13866
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

scale ratings do not work in forum

Created: 10/Mar/08 07:39 PM   Updated: 02/Apr/08 03:37 AM
Return to search
Component/s: Forum
Affects Version/s: 1.9
Fix Version/s: 1.9.1

Issue Links:
Dependency
 

Participants: Eloy Lafuente (stronk7), Matt Gibson and Petr Skoda
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 10/Mar/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
        // it could throw off the grading if count and sum returned a rawgrade higher than scale
        // so to prevent it we review the results and ensure that rawgrade does not exceed the scale, if it does we set rawgrade = scale (i.e. full credit)

the trouble is that forum->scale is NEGATIVE in case of scale ratings

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Mar/08 07:40 PM
MDL-13866 scale ratings do not work in forum
MODIFY mod/forum/lib.php   Rev. 1.609.2.35    (+13 -4 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 10/Mar/08 07:41 PM
MDL-13866 scale ratings do not work in forum; merged from MOODLE_19_STABLE
MODIFY mod/forum/lib.php   Rev. 1.644    (+13 -4 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Mar/08 07:45 PM
MDL-13866 scale ratings do not work in forum; merged from MOODLE_19_STABLE
MODIFY mod/forum/version.php   Rev. 1.69.2.2    (+2 -2 lines)
MODIFY mod/forum/db/upgrade.php   Rev. 1.5.2.1    (+9 -9 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 10/Mar/08 07:46 PM
MDL-13866 scale ratings do not work in forum; merged from MOODLE_19_STABLE
MODIFY mod/forum/db/upgrade.php   Rev. 1.6    (+9 -9 lines)
MODIFY mod/forum/version.php   Rev. 1.71    (+2 -2 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/08 06:16 AM
MDL-13866 fixed stupid bug in my last commit
MODIFY mod/forum/lib.php   Rev. 1.609.2.36    (+7 -4 lines)
MODIFY mod/forum/lib.php   Rev. 1.609.2.37    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 11/Mar/08 06:18 AM
MDL-13866 fixed stupid bug in my last commit; merged from MOODLE_19_STABLE
MODIFY mod/forum/lib.php   Rev. 1.645    (+8 -5 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/08 06:18 AM
MDL-13866 scale ratings do not work in forum
MODIFY mod/forum/version.php   Rev. 1.69.2.3    (+2 -2 lines)
MODIFY mod/forum/db/upgrade.php   Rev. 1.5.2.2    (+2 -2 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 11/Mar/08 06:19 AM
MDL-13866 scale ratings do not work in forum; merged from MOODLE_19_STABLE
MODIFY mod/forum/db/upgrade.php   Rev. 1.7    (+2 -2 lines)
MODIFY mod/forum/version.php   Rev. 1.72    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 16/Mar/08 07:50 AM
MDL-13866 adding warning that regrading of forums may take a while
MODIFY mod/forum/db/upgrade.php   Rev. 1.5.2.3    (+2 -1 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 16/Mar/08 07:51 AM
MDL-13866 adding warning that regrading of forums may take a while; merged from MOODLE_19_STABLE
MODIFY mod/forum/db/upgrade.php   Rev. 1.8    (+2 -1 lines)