[#MDL-13884] Students assigned at site or course category level do not appear in grader report

Issue Details (XML | Word | Printable)

Key:	MDL-13884
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Blocker
Assignee:	Petr Skoda
Reporter:	Nicolas Connault
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Students assigned at site or course category level do not appear in grader report

Created: 11/Mar/08 04:52 PM Updated: 15/Apr/08 09:33 AM

Return to search

Component/s:

Gradebook

Affects Version/s:

1.9

Fix Version/s:

1.9.1

File Attachments:

grader_sorting.patch (4 kB)

Participants:	Eloy Lafuente (stronk7), Nicolas Connault and Petr Skoda
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	11/Mar/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Students assigned at site or course category levels DO NOT appear in the grader report. They can be assigned to course groups, but these do not appear either in the report until course-assigned students are added to them.

The reason is probably the very simple SQL in the grader report lib that fetches the list of students.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 11/Mar/08 04:53 PM

Workaround - assign students in course context only.

Petr Skoda made changes - 11/Mar/08 05:49 PM

Field	Original Value	New Value
Assignee	Nicolas Connault [ nicolasconnault ]	Petr Skoda [ skodak ]

Petr Skoda made changes - 11/Mar/08 05:49 PM

Attachment

grader_sorting.patch [ 13330 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 11/Mar/08 06:12 PM

could be solved by adding $parent=true to get_role_users() call, but I think for transparency we should use similar queries in both cases so that the results are guaranteed to be consistent even if get_role_users() changes

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/08 06:50 PM

~~MDL-13884~~ Students assigned at site or course category level do not appear in grader report

MODIFY

grade/report/grader/lib.php

Rev. 1.98.2.40

(+33 -26 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 11/Mar/08 06:51 PM

~~MDL-13884~~ Students assigned at site or course category level do not appear in grader report; merged from MOODLE_19_STABLE

MODIFY

grade/report/grader/lib.php

Rev. 1.139

(+33 -26 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 11/Mar/08 06:54 PM

patch committed, please reopen in case of any problems.
thanks

Petr Skoda made changes - 11/Mar/08 06:54 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		1.9.1 [ 10240 ]

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/08 07:50 PM

~~MDL-13884~~ fixed incorrect left join, thanks Tim

MODIFY

grade/report/grader/lib.php

Rev. 1.98.2.41

(+2 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 11/Mar/08 07:53 PM

~~MDL-13884~~ fixed incorrect left join, thanks Tim; merged from MOODLE_19_STABLE

MODIFY

grade/report/grader/lib.php

Rev. 1.140

(+2 -2 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 11/Mar/08 07:53 PM

fixed incorrect left join - pointed out by Tim, sorry

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 15/Apr/08 09:33 AM

Verified. Closing....ciao

Eloy Lafuente (stronk7) made changes - 15/Apr/08 09:33 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee		stronk7

All content on this web site is made available under the GNU General Public License, unless otherwise stated.