Moodle

Underlining lost when forum post is submitted

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Forum
  • Labels:
    None
  • Environment:
    demo.moodle.org (1.9+) today, also in moodle.org forums
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

To duplicate the problem: create a forum post and underline some text. Submit the post and then view it.

In the original text, the underlined portion is surrounded by span tags:

<span style="text-decoration: underline;">blah blah blah</span>

After submitting, the style is lost:

<span>blah blah blah</span>

Issue Links

This issue has been marked as being related by:
MDL-14595 like mdl-13886 styles are broken Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Adding Petr here... he knows a lot about kses and cleaning of texts... ciao

Show
Eloy Lafuente (stronk7) added a comment - Adding Petr here... he knows a lot about kses and cleaning of texts... ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

(it sounds to me vaguely that kses used to remove inline styles... just a possible cause)

Show
Eloy Lafuente (stronk7) added a comment - (it sounds to me vaguely that kses used to remove inline styles... just a possible cause)
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs, thanks for the report

Show
Petr Škoda (skodak) added a comment - fixed in cvs, thanks for the report
Hide
Permalink
John Isner added a comment -

The bug may not be completely fixed. See discussion http://moodle.org/mod/forum/discuss.php?d=96803 "html editor and indents"

In this case, indents (inserted using the indent button) are being disarded.

To reproduce, type a line

indented

and indent using indent button.

Before posting, toggle into HTML mode:
<div style="margin-left: 40px;">indented</div>

Post, then re-edit, toggle into HTML mode:
<div>indented</div>

Observed on moodle.org forums (1.9+)

Show
John Isner added a comment - The bug may not be completely fixed. See discussion http://moodle.org/mod/forum/discuss.php?d=96803 "html editor and indents" In this case, indents (inserted using the indent button) are being disarded. To reproduce, type a line indented and indent using indent button. Before posting, toggle into HTML mode: <div style="margin-left: 40px;">indented</div> Post, then re-edit, toggle into HTML mode: <div>indented</div> Observed on moodle.org forums (1.9+)

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.