[#MDL-13932] Rewrite RSS block

Issue Details (XML | Word | Printable)

Key:	MDL-13932
Type:	Task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Dan Poltawski
Reporter:	Nicolas Connault
Votes:	1
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Rewrite RSS block

Created: 14/Mar/08 07:57 PM Updated: 30/Jul/09 10:14 PM

Return to search

Component/s:

RSS

Affects Version/s:

2.0

Fix Version/s:

2.0

File Attachments:

rssrework250609.patch (67 kB)

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-7946~~ Use simplepie instead of magpie for rss parsing

Participants:	Charles Fulton, Dan Poltawski, Nicolas Connault, Petr Skoda and Tim Hunt
Security Level:	None
Resolved date:	30/Jul/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

Update simplepie lib to latest version and use it instead of magpie. Rewrite role-related code so that the block finally works well for student submissions and on the MyMoodle page.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Charles Fulton added a comment - 18/Jul/08 01:44 AM

There's traction on #7946--a patch for using simple instead of magpie has been submitted. This has no effect on the role issue.

[ Permalink | « Hide ]

Dan Poltawski added a comment - 12/Apr/09 06:35 AM - edited

I am in the middle of doing this, converting to simplepie and refactoring the block a lot

see:
http://git.danpoltawski.co.uk/?p=moodle.git;a=shortlog;h=refs/heads/simplepie

[ Permalink | « Hide ]

Dan Poltawski added a comment - 13/Apr/09 10:49 PM

Please review the attached rework of the RSS block.

With this refactor i've:

Moved to simplepie
Done a big cleanup of code, fixing some issues like lack of sesskey protection/proper capability checking
Tried not to change the output at this stage

I've tried to leave alone bits which might be affected by tims navigation 2.0 stuff alone & keep the output/weird behaviour as it was.

You can see a log of the commits here:
http://git.danpoltawski.co.uk/?p=moodle.git;a=shortlog;h=88ee1346b1092767f9ca90fde015102242664881

[ Permalink | « Hide ]

Dan Poltawski added a comment - 13/Apr/09 11:36 PM

Uploading rssrework02.patch as i've now commited the simplepie library as suggested by Petr

blocks/rss_client/block_rss_client.php | 477 +++++++++++++------------
blocks/rss_client/block_rss_client_action.php | 384 ++++++++------------
blocks/rss_client/config_instance.html | 10 +-
blocks/rss_client/db/upgrade.php | 13 +-
blocks/rss_client/locallib.php | 177 +++++++++
blocks/rss_client/settings.php | 11 +-
lang/en_utf8/block_rss_client.php | 1 +
lib/rsslib.php | 197 +----------
8 files changed, 599 insertions, 671 deletions

[ Permalink | « Hide ]

Dan Poltawski added a comment - 14/Apr/09 03:19 AM

Revised to fix the casing problems

[ Permalink | « Hide ]

Petr Skoda added a comment - 14/Apr/09 04:00 AM

The patch is confusing my Netbeans, it just creates dev/null directory in my checkout :-O
I suppose the problem is in:
— a/blocks/rss_client/block_rss_client.php
+++ b/blocks/rss_client/block_rss_client.php

[ Permalink | « Hide ]

Dan Poltawski added a comment - 14/Apr/09 05:57 AM

Finally - a patch which applies to CVS atm..

[ Permalink | « Hide ]

Dan Poltawski added a comment - 14/Apr/09 07:27 AM

Note to readers: cvs-compatible03.patch is the patch of interest atm

(I can't remove the existing patches)

[ Permalink | « Hide ]

Dan Poltawski added a comment - 26/Jun/09 02:15 AM

Attaching latest patch against head which works with Tims pagelib changes.

[ Permalink | « Hide ]

Tim Hunt added a comment - 29/Jul/09 07:19 PM

I just did a huge chunk of changes to the manage feeds UI in head. I hope it is not too badly broken. The code is certainly cleaner (but could probably do with a few more comments).

[ Permalink | « Hide ]

Dan Poltawski added a comment - 29/Jul/09 09:46 PM

I took the next step and commited the switch to simplepie using a subset of my previous changes. I will remove some of the other obsolete references and wait for a final OK before removing magpie completely

[ Permalink | « Hide ]

Dan Poltawski added a comment - 30/Jul/09 10:14 PM

Closing this and going to file seperate issues for problems as I find them.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.