Moodle

Wrong group handle in the forum

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Using forum in visible group mode I find, that it can't correctly handle groups in 1.9 ( bug preserves in current version of Moodle 1.9+).
'Group' column is wrong and combo-box too.

On the attachment you can see fragments of two pages: one from the forum (it tells, that group of the student is FEVT-1.1S), another from the user info (link from the forum page) that tells, that group for this student is FEVT-1.2S (which is correct).

Issue Links

This issue has been marked as being related by:
MDL-14429 improve forum group mode docs/help Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Helen, can you try to reproduce this? If reproducible, I think Petr could handle this.

Raising to "major" and addressing to 1.9.1.

Thanks for the report, Oleg!

Show
Eloy Lafuente (stronk7) added a comment - Helen, can you try to reproduce this? If reproducible, I think Petr could handle this. Raising to "major" and addressing to 1.9.1. Thanks for the report, Oleg!
Hide
Permalink
Oleg Sychev added a comment -

Maybe this can help to reproduce the bug: the groups was created manually, but users was added to them via uploading a CSV file with group1 field. But other modules (quiz for example) understand these groups correctly.

Show
Oleg Sychev added a comment - Maybe this can help to reproduce the bug: the groups was created manually, but users was added to them via uploading a CSV file with group1 field. But other modules (quiz for example) understand these groups correctly.
Hide
Permalink
Oleg Sychev added a comment -

In some discussions forum doesn't display group at all, even with one post in discussion from the student.

Show
Oleg Sychev added a comment - In some discussions forum doesn't display group at all, even with one post in discussion from the student.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Did you switch the group type AFTER some post were already added?
Or did you cahnge the groups of users after they posted?

Forum does not support changing of group setting either in Forum settings or of given users because the original group id is stored in the post itself.

Show
Petr Škoda (skodak) added a comment - Did you switch the group type AFTER some post were already added? Or did you cahnge the groups of users after they posted? Forum does not support changing of group setting either in Forum settings or of given users because the original group id is stored in the post itself.
Hide
Permalink
Oleg Sychev added a comment -

No. The global sequence of events was:
1. The course was cleared, to prepare it for the next academical year
2. Some new groups were added
3. Students was uploaded in bulk via CSV file, with enrollment in the course and group
4. A fter that students starts posting, but their groups remains unchanged

Furthermore, in many cases forum doesn't display group at all, thought student that starts discussion belonged to the group.

Show
Oleg Sychev added a comment - No. The global sequence of events was: 1. The course was cleared, to prepare it for the next academical year 2. Some new groups were added 3. Students was uploaded in bulk via CSV file, with enrollment in the course and group 4. A fter that students starts posting, but their groups remains unchanged Furthermore, in many cases forum doesn't display group at all, thought student that starts discussion belonged to the group.
Hide
Permalink
Oleg Sychev added a comment -

I probably can help you determine source of problems. When teacher, belonging to multiple groups, starts discussion in Visible Groups mode , the group column for discussion depends on group setting, used to view forum contents: when using "all" the group column is empty, when view posts by single group - discussion marked by this group.

Probably this leads to the error: in visible groups mode student can starts discussion while viewing other group and the discusion receive the wrong group identifier.

Furthemore, the group settings to view in Visible Groups mode in all moodle windows during one session (and maybe not from one session, but from all moodle windows opens simultaneously) are one value, so I can open forum page, then view quiz attempt from some student using his group to filter attepts, and start discussion, which results in marking discussion by this group.

Suggested solution is to check to which group given user belongs rather than to rely on group setting from environment globals (which has another purpose).

Show
Oleg Sychev added a comment - I probably can help you determine source of problems. When teacher, belonging to multiple groups, starts discussion in Visible Groups mode , the group column for discussion depends on group setting, used to view forum contents: when using "all" the group column is empty, when view posts by single group - discussion marked by this group. Probably this leads to the error: in visible groups mode student can starts discussion while viewing other group and the discusion receive the wrong group identifier. Furthemore, the group settings to view in Visible Groups mode in all moodle windows during one session (and maybe not from one session, but from all moodle windows opens simultaneously) are one value, so I can open forum page, then view quiz attempt from some student using his group to filter attepts, and start discussion, which results in marking discussion by this group. Suggested solution is to check to which group given user belongs rather than to rely on group setting from environment globals (which has another purpose).
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be fixed now, please test and reopen if necessary

thanks for the report!

Show
Petr Škoda (skodak) added a comment - should be fixed now, please test and reopen if necessary thanks for the report!
Hide
Permalink
Oleg Sychev added a comment -

Was the patch included in last weekly build? I attempt it and problem with groups remains, as it were.
I can't load moodle from CVS now.

Show
Oleg Sychev added a comment - Was the patch included in last weekly build? I attempt it and problem with groups remains, as it were. I can't load moodle from CVS now.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I fixed some problems there. But I guess not the way you wanted it to work. When visible groups used, students may start a discussion in any group - the problem is that this change would not be backwards compatible and as such can not be done in 1.9.x sorry. Please create a new tracker issues for this problem if needed.

Show
Petr Škoda (skodak) added a comment - I fixed some problems there. But I guess not the way you wanted it to work. When visible groups used, students may start a discussion in any group - the problem is that this change would not be backwards compatible and as such can not be done in 1.9.x sorry. Please create a new tracker issues for this problem if needed.
Hide
Permalink
Petr Škoda (skodak) added a comment -

reopening - you were right, students were not allowed to post in groups they are not members of in visible mode in 1.6 - going to fix it today, sorry

Thanks Eloy for reminding me how it worked in 1.6

Show
Petr Škoda (skodak) added a comment - reopening - you were right, students were not allowed to post in groups they are not members of in visible mode in 1.6 - going to fix it today, sorry Thanks Eloy for reminding me how it worked in 1.6
Hide
Permalink
Petr Škoda (skodak) added a comment -

this should be fixed finally now, going to add new subtask for docs improvements

thanks for the report!

Show
Petr Škoda (skodak) added a comment - this should be fixed finally now, going to add new subtask for docs improvements thanks for the report!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Closing. Thanks!

People

Vote (1)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.