Moodle

"enrol_ldap_autocreate" create courses, even if "enrol_ldap_autocreate" is set to "no"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.4
  • Fix Version/s: 1.8.11, 1.9.7, 2.0
  • Component/s: Course
  • Labels:
    None
  • Environment:
    Debian Linux 4.0, PHP Version 4.4.4-8, Apache 1.3.34
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

"enrol_ldap_autocreate" create courses, even if "enrol_ldap_autocreate" is set to "no"

so i have done the following changes on enrol/ldap/enrol.php:
from:
if (!is_object($course_obj){
// ok, now then let's create it! print "Creating Course $idnumber...";

to:
if (!is_object($course_obj) && $CFG->enrol_ldap_autocreate) {
// ok, now then let's create it! print "Creating Course $idnumber...";

it's this right? is this a bug?

Regards
Bruno

Issue Links

Activity

Hide
Clinton Graham added a comment -

I agree. This is an obvious bug with a clear fix.

Show
Clinton Graham added a comment - I agree. This is an obvious bug with a clear fix.
Hide
Iñaki Arenaza added a comment -

This should be fixed in CVS for 1.8, 1.9 and HEAD.

Thanks a lot Bruno and Clinton for the heads up

Saludos,
Iñaki.

Show
Iñaki Arenaza added a comment - This should be fixed in CVS for 1.8, 1.9 and HEAD. Thanks a lot Bruno and Clinton for the heads up Saludos, Iñaki.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: