as part of the migration from 1.8 to 1.9 user images have been moved from the old "users" dir to a new "user" dir, using one extra level in the new storage to prevent some problems in BIG sites.

Curiously, it sees that the new "user" structure was properly generated in your site (from screenshot), with user 2 images ready to be served.

Can you confirm what version of this script:

moodle/user/pix.php

are you using? Just to be 100% sure you aren't running a outdated version.

Assigning this to Nicolas... hi worked on the user-images migration and has more knowledge about what can be failing... ciao

I've been doing some testing in preparation for upgrading from 1.8.2 to 1.9 (20080409) and I am experiencing a similar problem to the one mentioned above. After upgrading, some, but not all, of the user pictures display the default image instead of the one that they uploaded.

I did a diff on the two versions of pix.php and I've pasted the results below:

--------------------------------------------------
~/compare ]$ diff old.php new.php
1c1
< <?PHP // $Id: pix.php,v 1.16 2007/01/26 20:15:54 skodak Exp $
—
> <?PHP // $Id: pix.php,v 1.16.4.1 2007/10/11 11:12:52 nicolasconnault Exp $
21c21
< $pathname = $CFG->dataroot.'/users/'.$userid.'/'.$image;
—
> $pathname = make_user_directory($userid, true) . "/$image";
-----------------------------------------------------

Now, out of curiosity I changed the $pathname assignment in the new file back to the old definition and the user pictures display properly. So it seems that something is not working properly for us with the new definition.

Any ideas?

changing to the old $pathname works because old images are left in the original place ("users" dir). But all the new images and so on will go to the new "user" dir, so won't display ok using the old $pathname.

Anyway, it's seems that we are receiving more than one reports about missing images. Andrew, could you, please:

• did you get any error in the upgrade process?
• give us some user ids that are failing after the upgrade. Are you able to find some pattern is those ids (for example, "al those ending in 00 aren't working" or "all those bigger that 456 arent working".
• can you search for them in the new "user" dir (should be below on intermendate.

Thanks!

To answer your other question, I did not get any error in the upgrade process (at least none that I saw).

I have also attached a screen shot of the old users directory and the new user directory.

Cheers,

-Andrew

I tried the silly php snippet in the attachement to copy missing directories
like
exec("rsync -a -v ".$path."users/".$user_dir."/"
." ".$path."user/".$group_dir."/".$user_dir."/");

I'm really suprised that this is listed as "Minor" - it may not create a functionality problem, but it really does look unprofessional.
I haven't had user images appear since March (after upgrade from 1.8 to 1.9+) - can we escalate this or at least try to find a workaround?