Issue Details (XML | Word | Printable)

Key: MDL-14022
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Anthony Borrow
Reporter: David Mudrak
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Moodle casts scale name into an integer number and may consider it as points

Created: 23/Mar/08 06:21 AM   Updated: 08/Jul/08 09:48 AM
Return to search
Component/s: Gradebook
Affects Version/s: 1.8.4
Fix Version/s: 1.8.6

File Attachments: 1. File MDL-14022.diff (1 kB)


Participants: Anthony Borrow and David Mudrak
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 05/Jul/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
Steps to reproduce
============

0. create a new empty course
1. create a new scale and name it e.g. "3 Nuts for Cinderella" (put an integer as a first part of the name)
2. create two new assignments - let us call them A and B
3. set maximum grade for the assignment A to 10 points
4. set the scale "3 Nuts for Cinderella" as a grading method of the assignment B
5. grade some submissions in both assignments
4. go to the grade book and see the total number of points in the header

What I expected to see
==============

Total points is 10 - because of assignment A. Scale grades are displayed but do not influence the total points.

What actually happened
===============

Total points is 13. Assignment A has maximum grade 10 points. Assignment B is considered to have maximum grade 3 points. Even students with 10 points from assignment 10 and the best scale item from assignment B can not reach 100% of points; they still have only 10 points of 13.

This happens always when the scale name may be casted into non-zero integer number.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
arborrow committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 05/Jul/08 10:58 AM
MDL-14022 - verifies that maxgrade is in fact a number before adding grade_against to totalpoints
MODIFY grade/lib.php   Rev. 1.65.2.16    (+4 -2 lines)