|
Matt Oquist made changes - 26/Mar/08 04:50 AM
This tarball includes patches for 1.6.6, 1.7.4, 1.8.4, and 1.9 build 20080325.
I've tested in 1.8.4 and 1.9, and the patches look correct for 1.6.6 and 1.7.4 on a casual visual inspection.
Matt Oquist made changes - 26/Mar/08 05:11 AM
Forgot to include the issue key last time; these patches note
edit: It just occurred to me that I should've used cvs to produce these patches. I dunno why I didn't...anyhoo, the patches are for question/type/multianswer/questiontype.php, which is not obvious by looking at them.
Matt Oquist made changes - 26/Mar/08 05:27 AM
Pierre Pichet made changes - 26/Mar/08 08:24 AM
I will work on this as this should be synchronized with MDL-13419 which is already CVS to HEAD and 19_STABLE.
Comparison of the proposed dispaly with mulchoice and match question types
Pierre Pichet made changes - 26/Mar/08 11:54 AM
the proposed patch use
echo "<em><small>$correctanswers_str</small></em>"; to display. I think the styles options should be used and I will study this further unless somebody have a proposal. Should we dispaly the selcect element like the the match question type even if in this case there is no correct answer available. The in-line restriction for Cloze proscrib the multiple choice radio button style that allows correct answers display. give your comments You're right to worry about these styles being hard-coded. I did that just to visually distinguish the correct answer text from the surrounding question text. Perhaps this isn't even necessary, but in any case I'd hate to see this fix held up by a styles issue. I'd rather see the patch applied without the "<em>" and "<small>" tags, and styles applied later after we come up with an acceptable way to do it.
As this is not a major bug but a useful feature, I prefer to do it correctly.
MDL-7494 also address the Cloze question display. In the mean time users can apply locally your patch or put the correct answer in the feedback field...
Pierre Pichet made changes - 29/Mar/08 02:50 AM
Pierre Pichet made changes - 15/May/08 11:18 PM
Use the popup to show the correct answer.
Here an example with feedback.
Pierre Pichet made changes - 15/May/08 11:22 PM
Here an example with only correct answer.
Pierre Pichet made changes - 15/May/08 11:23 PM
Using the popup does not disturb the actual display.
I am planning to offer some display options to cloze question.see MDL-14763. Need to complete tests before CVS.
pichetp committed 1 file to 'Moodle CVS' - 19/May/08 01:22 AM
pichetp committed 1 file to 'Moodle CVS' - 19/May/08 07:08 AM
martignoni committed 1 file to 'Lang CVS' - 20/May/08 04:52 AM
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 21/May/08 12:57 PM
pichetp committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/May/08 06:33 AM
pichetp committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/May/08 06:39 AM
Pierre Pichet made changes - 11/Dec/08 05:21 AM
Was fixed as MDL-14763 is fixed and closed
Pierre Pichet made changes - 11/Dec/08 05:22 AM
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
I have a patch that takes care of it, at least for shortanswer-type Cloze questions. I'll attach the patch in a few minutes.
I'm not really worried about this problem for any question types other than shortanswer, since that's all we're using in production. But the patch will also take care of NUMERICAL (though I haven't tested that, it's the same case). Multiple choice doesn't need it so much, because the teacher can probably figure out what Moodle was expecting even if it isn't specified.