Moodle

Course totals are missing in gradebook when updating 1.8.4 > 1.9.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.3
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Course totals are not shown in Gradebook, when upgrading from 1.8.4 to 1.9. Unit tests are showing error reports, see forums:
http://moodle.org/mod/forum/discuss.php?d=93371
http://moodle.org/mod/forum/discuss.php?d=93296

  1. db-190-grade_items.sql
    26/Mar/08 7:48 PM
    25 kB
    Martin O'Mahony
  2. unit_test_1_9.pdf
    26/Mar/08 9:12 PM
    200 kB
    Jani Lemmetyinen

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

Hello,
I can not fix this if I can not reproduce it.
I need much more information:

  • course backup (both from 1.8.x and 1.9+)
  • or db dump
  • or at least contents of the new grade_items table
Show
Petr Škoda (skodak) added a comment - Hello, I can not fix this if I can not reproduce it. I need much more information:
  • course backup (both from 1.8.x and 1.9+)
  • or db dump
  • or at least contents of the new grade_items table
Hide
Martin O'Mahony added a comment -

mdl_grade_items table taken from our productive Moodle system after upgrading from 1.8.4+ to 1.9+ (we had to roll back to 1.8.4+).

Show
Martin O'Mahony added a comment - mdl_grade_items table taken from our productive Moodle system after upgrading from 1.8.4+ to 1.9+ (we had to roll back to 1.8.4+).
Hide
Jani Lemmetyinen added a comment -

Here's some information about Moodle 1.9 environment:
mysql 5.0.37, php 5.2.3 (build 3790, date may 31 2007)

Unit test data is attached (pdf). Moodle language is Finnish
Epäonnistui = Fail

I cannot yet add course backups here - backups are from our customer's production environment with real students and they must check some legal things first.

Show
Jani Lemmetyinen added a comment - Here's some information about Moodle 1.9 environment: mysql 5.0.37, php 5.2.3 (build 3790, date may 31 2007) Unit test data is attached (pdf). Moodle language is Finnish Epäonnistui = Fail I cannot yet add course backups here - backups are from our customer's production environment with real students and they must check some legal things first.
Hide
Martin Dougiamas added a comment -

I've added a separate issue for the Unit test report results because it may not be related: MDL-14065

Show
Martin Dougiamas added a comment - I've added a separate issue for the Unit test report results because it may not be related: MDL-14065
Hide
Martin O'Mahony added a comment -

The 1.8.4+ installation that served as a basis for the upgrade reports the following failure during the unit tests:

[MySQL specific fail message skipped]

Starting digest processing... Cleaned old digest records

Fail: question/type/numerical/simpletest/testquestiontype.php / ? / ?
Bad GroupTest [/srv/www/htdocs/moodle/question/type/numerical/simpletest/testquestiontype.php] with error [Creating default object from empty value]

12/12 test cases complete: 209 passes, 3 fails and 0 exceptions.

Maybe this is relevant?

Show
Martin O'Mahony added a comment - The 1.8.4+ installation that served as a basis for the upgrade reports the following failure during the unit tests: [MySQL specific fail message skipped] Starting digest processing... Cleaned old digest records Fail: question/type/numerical/simpletest/testquestiontype.php / ? / ? Bad GroupTest [/srv/www/htdocs/moodle/question/type/numerical/simpletest/testquestiontype.php] with error [Creating default object from empty value] 12/12 test cases complete: 209 passes, 3 fails and 0 exceptions. Maybe this is relevant?
Hide
Michelle Moore added a comment -

I'm not sure if this is related, but Helen and I spent some time troubleshooting an issue in which course totals wouldn't appear either.

My site is running Moodle 1.9 + (Build: 20080320) and had been upgraded from 1.8 in the 1.9 beta days. The course I'm working in did not exist on the 1.8.4 server though--some activities have been imported from prior courses, but the students and grades are all new to 1.9.

In my gradebook, I have created two categories--one for graded activities and one for non-graded using the instructions here: http://docs.moodle.org/en/Grades_FAQ#How_can_I_grade_some_of_my_activities_without_the_results_affecting_my_students.27_course_total.3F
The graded items included only numerical scores while some of the non-graded activities include ratings with custom scales.

Then, I used the instructions in this forum: http://moodle.org/mod/forum/discuss.php?d=92211#p408716 to add a column for letter grades to the gradebook to show along with the percents. Since my course only has one category for graded assignments, my calculation was a bit different (simpler) than those in the samples--only =[[graded_activities]].

After I had everything set up, I logged in as a student to confirm what they would see and saw that the course totals and letter grade did not appear, just a hyphen as described above. In my view as the instructor/administrator though, I could see both the letter grades and the course totals and everything appeared to work properly.

Helen worked with me to solve the problem--while we're not sure what caused it, she found that eliminating the letter grade calculation solved the problem and students were able see the course total.

Show
Michelle Moore added a comment - I'm not sure if this is related, but Helen and I spent some time troubleshooting an issue in which course totals wouldn't appear either. My site is running Moodle 1.9 + (Build: 20080320) and had been upgraded from 1.8 in the 1.9 beta days. The course I'm working in did not exist on the 1.8.4 server though--some activities have been imported from prior courses, but the students and grades are all new to 1.9. In my gradebook, I have created two categories--one for graded activities and one for non-graded using the instructions here: http://docs.moodle.org/en/Grades_FAQ#How_can_I_grade_some_of_my_activities_without_the_results_affecting_my_students.27_course_total.3F The graded items included only numerical scores while some of the non-graded activities include ratings with custom scales. Then, I used the instructions in this forum: http://moodle.org/mod/forum/discuss.php?d=92211#p408716 to add a column for letter grades to the gradebook to show along with the percents. Since my course only has one category for graded assignments, my calculation was a bit different (simpler) than those in the samples--only =[[graded_activities]]. After I had everything set up, I logged in as a student to confirm what they would see and saw that the course totals and letter grade did not appear, just a hyphen as described above. In my view as the instructor/administrator though, I could see both the letter grades and the course totals and everything appeared to work properly. Helen worked with me to solve the problem--while we're not sure what caused it, she found that eliminating the letter grade calculation solved the problem and students were able see the course total.
Hide
Helen Foster added a comment -

Just to add to Michelle's comment, I've so far failed to work out a way to reproduce the problem on a 1.9 test site, though I hope to investigate the issue more thoroughly next week.

Show
Helen Foster added a comment - Just to add to Michelle's comment, I've so far failed to work out a way to reproduce the problem on a 1.9 test site, though I hope to investigate the issue more thoroughly next week.
Hide
Jani Lemmetyinen added a comment -

Some more testing...I'm not sure if this is related

I make a course backup from Moodle 1.8.2 (php 5.1.6, mysql 4.1.20). Then I restored this backup file to 1.9 (mysql 5.0.37, php 5.2.3).
Course totals were shown normally.

I also made unit test in 1.8.2. I'll post errors to MDL-14065

I'll test this later with 1.8.4 > 1.9

Show
Jani Lemmetyinen added a comment - Some more testing...I'm not sure if this is related I make a course backup from Moodle 1.8.2 (php 5.1.6, mysql 4.1.20). Then I restored this backup file to 1.9 (mysql 5.0.37, php 5.2.3). Course totals were shown normally. I also made unit test in 1.8.2. I'll post errors to MDL-14065 I'll test this later with 1.8.4 > 1.9
Hide
Susan Mangan added a comment -

Hi there, just wanted to add a comment (might be helpful, might not be?!) we also just upgraded our dev server to 1.9 from 1.8.4 and had the same problem with course totals not appearing in the gradebook with data brought over. Anything created new displayed fine.

What I've uncovered so far is that courses that had no weighted categories set up were brought over using 'weighted mean of grades', so by changing this to 'simple weighted mean of grades', the totals appear.

I haven't completely worked through the problem with totals with weighted categories. Some seemed to be showing totals fine and with others that are not displaying totals, I do know that if you enter a weight within an Item within a category, the totals then appear. This might have something to do with parent/child relationship? I'm still toying around with it but have been able to get the totals to appear fiddling with the aggregation settings.

Show
Susan Mangan added a comment - Hi there, just wanted to add a comment (might be helpful, might not be?!) we also just upgraded our dev server to 1.9 from 1.8.4 and had the same problem with course totals not appearing in the gradebook with data brought over. Anything created new displayed fine. What I've uncovered so far is that courses that had no weighted categories set up were brought over using 'weighted mean of grades', so by changing this to 'simple weighted mean of grades', the totals appear. I haven't completely worked through the problem with totals with weighted categories. Some seemed to be showing totals fine and with others that are not displaying totals, I do know that if you enter a weight within an Item within a category, the totals then appear. This might have something to do with parent/child relationship? I'm still toying around with it but have been able to get the totals to appear fiddling with the aggregation settings.
Hide
Ralf Seliger added a comment -

I don't know if this issue is a bug, after all. I had the same problem and resolved it by following Nicolas Connault's advice (see forum thread http://moodle.org/mod/forum/discuss.php?d=98243). I just had to change the aggregation type to "Mean of grades" to make it work.

Show
Ralf Seliger added a comment - I don't know if this issue is a bug, after all. I had the same problem and resolved it by following Nicolas Connault's advice (see forum thread http://moodle.org/mod/forum/discuss.php?d=98243). I just had to change the aggregation type to "Mean of grades" to make it work.
Hide
Howard Miller added a comment -

I can only confirm having the same problem. The workaround seems to be to force the Gradebook to recalculate the total by fiddling with its category's aggregation strategy. Even this doesn't always work. Is it not easiest to simply have an option to "brute force" recalculate (and check they exist) the totals?

Show
Howard Miller added a comment - I can only confirm having the same problem. The workaround seems to be to force the Gradebook to recalculate the total by fiddling with its category's aggregation strategy. Even this doesn't always work. Is it not easiest to simply have an option to "brute force" recalculate (and check they exist) the totals?
Hide
Andrea Bicciolo added a comment - - edited

Experienced same issue, as for (duplicated) MDL-15051

Show
Andrea Bicciolo added a comment - - edited Experienced same issue, as for (duplicated) MDL-15051
Hide
Petr Škoda (skodak) added a comment -

I can not reproduce this in 1.9.1 and later code. Please note that the upgrade code is different in 1.9.0 - there was a problem with weights, you can usually fix it by setting up weights for categories or by changing aggregation types.

Petr

Show
Petr Škoda (skodak) added a comment - I can not reproduce this in 1.9.1 and later code. Please note that the upgrade code is different in 1.9.0 - there was a problem with weights, you can usually fix it by setting up weights for categories or by changing aggregation types. Petr
Hide
Nicolas Connault added a comment -

Is this still an issue? Please report or the issue will be considered solved.

Show
Nicolas Connault added a comment - Is this still an issue? Please report or the issue will be considered solved.
Hide
Andrea Bicciolo added a comment -

Well, about all sites where we upgraded, the problem appeared. Basically it seems related to the default aggregation selected. On freshly installed 1.9 it is set to "Simple mean of grades", while on upgraded is set to "Mean of grades"

Show
Andrea Bicciolo added a comment - Well, about all sites where we upgraded, the problem appeared. Basically it seems related to the default aggregation selected. On freshly installed 1.9 it is set to "Simple mean of grades", while on upgraded is set to "Mean of grades"
Hide
Martin Dougiamas added a comment -

Looks like we can't duplicate any of this on recent versions of Moodle 1.9 (eg 1.9.2) so it appears to be related to earlier bugs in the upgrade using 1.9.0 (since fixed).

Please re-eopen if you or anyone else can duplicate the problem using 1.9.2 or later.

Show
Martin Dougiamas added a comment - Looks like we can't duplicate any of this on recent versions of Moodle 1.9 (eg 1.9.2) so it appears to be related to earlier bugs in the upgrade using 1.9.0 (since fixed). Please re-eopen if you or anyone else can duplicate the problem using 1.9.2 or later.
Hide
Karen Liebhaber added a comment -

I, also, am having the same trouble. At times changing the aggregation method will solve the problem; at others times, nothing will solve the problem. We've went so far as to export out and recreate and entire course's gradebook to solve the problem.

Show
Karen Liebhaber added a comment - I, also, am having the same trouble. At times changing the aggregation method will solve the problem; at others times, nothing will solve the problem. We've went so far as to export out and recreate and entire course's gradebook to solve the problem.
Hide
Felicia Berryman added a comment - - edited

This caused some problems at my institution running Moodle 2.0. After investigation, we were able to reproduce the problem by dropping students and then re-adding them without the checking the option to "Recover user's old grades if possible." We fixed the problem by dropping the students and re-adding them manually while keeping this box checked. The programmer at my institution is working on "checking" this option for our auto add/drop functionality. Should this checkbox be off by default? I'm going to post a related report to this.

Show
Felicia Berryman added a comment - - edited This caused some problems at my institution running Moodle 2.0. After investigation, we were able to reproduce the problem by dropping students and then re-adding them without the checking the option to "Recover user's old grades if possible." We fixed the problem by dropping the students and re-adding them manually while keeping this box checked. The programmer at my institution is working on "checking" this option for our auto add/drop functionality. Should this checkbox be off by default? I'm going to post a related report to this.
Hide
Felicia Berryman added a comment -

I created MDL-27996 which may be related to this.

Show
Felicia Berryman added a comment - I created MDL-27996 which may be related to this.

Dates

  • Created:
    Updated:
    Resolved: