Issue Details (XML | Word | Printable)

Key: MDL-14065
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Nicolas Connault
Reporter: Martin Dougiamas
Votes: 1
Watchers: 9
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Unit tests showing many failures of all kinds

Created: 26/Mar/08 10:09 PM   Updated: 21/Apr/08 09:54 PM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 1.9.1, 2.0

Issue Links:
Duplicate
 
Relates
 

Participants: Jani Lemmetyinen, Martin Dougiamas and Nicolas Connault
Security Level: None
QA Assignee: Martin Dougiamas
Resolved date: 28/Mar/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Nicolas, can you explore why the Unit tests are currently showing so many failures in Moodle 1.9? is this just a recent regression?

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas made changes - 26/Mar/08 10:11 PM
Field Original Value New Value
Link This issue has been marked as being related by MDL-14059 [ MDL-14059 ]
[ Permalink | « Hide ]
Jani Lemmetyinen added a comment - 27/Mar/08 05:12 PM
Here's some Unit test reports, related to MDL-14059.
---------------------------------
This one is from Moodle 1.8.2. When restoring backup from 1.8.2 to 1.9, course totals were OK.

Moodle testit: KAIKKI
Epäonnistui: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_get_user / ?
True assertion got False at [/home/webadmin/mdemo.planeetta.com/html/moodle/group/simpletest/test_basicgrouplib.php line 37]
Epäonnistui: lib/simpletest/testdmllib.php / ? datalib_test / ? test_insert_record / ?
Insert bad data - error should have been printed. This is known not to work on MySQL. at [/home/webadmin/mdemo.planeetta.com/html/moodle/lib/simpletest/testdmllib.php line 286]
12/12 test cases complete: 179 passes, 3 fails and 0 exceptions.
Suorita testi klo 27-03-2008 09:44 EETUsing SimpleTest version 1.0.1alpha3.
----------------------


[ Permalink | « Hide ]
Jani Lemmetyinen added a comment - 27/Mar/08 05:34 PM
And this one is from moodle 1.8.4, Mysql 5.0.37, php 5.2.5
When updating this site to 1.9., course totals were missing.
------------------------------

Moodle unit tests: ALL
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_get_user / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 33]
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_add_member / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 74]
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_add_member / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 75]
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_add_member / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 76]
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_add_member / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 78]
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_add_member / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 80]
Fail: group/simpletest/test_basicgrouplib.php / ? basicgrouplib_test / ? test_remove_member / ?
True assertion got False at [C:\Apache2.2\htdocs\palautus_moodle\group\simpletest\test_basicgrouplib.php line 84]
Fail: lib/simpletest/testdmllib.php / ? datalib_test / ? test_insert_record / ?
Insert bad data - error should have been printed. This is known not to work on MySQL. at [C:\Apache2.2\htdocs\palautus_moodle\lib\simpletest\testdmllib.php line 286]
Starting digest processing... Cleaned old digest records Sending forum digests: Thursday, 27 March 2008, 10:17 AM
Fail: question/type/numerical/simpletest/testquestiontype.php / ? / ?
Bad GroupTest [C:\Apache2.2\htdocs\palautus_moodle/question/type/numerical/simpletest/testquestiontype.php] with error [Creating default object from empty value]
12/12 test cases complete: 202 passes, 10 fails and 0 exceptions.
Run at 27-03-2008 10:17 EET.Using SimpleTest version 1.0.1alpha3.


Nicolas Connault committed 3 files to 'Moodle CVS' - 27/Mar/08 09:08 PM
MDL-14065 Fixed gradebook unit tests, including a bug fix in grade_item class
MODIFY lib/grade/simpletest/testgradegrades.php   Rev. 1.11    (+6 -3 lines)
MODIFY lib/grade/grade_item.php   Rev. 1.168    (+2 -2 lines)
MODIFY lib/grade/simpletest/testgradeitem.php   Rev. 1.16    (+17 -25 lines)
Nicolas Connault committed 2 files to 'Moodle CVS' - 28/Mar/08 02:08 AM
MDL-14065 Commented out buggy backuplib tests, and replaced E_ALL with DEBUG_DEVELOPER in dmllib tests
MODIFY lib/simpletest/testbackuplib.php   Rev. 1.3    (+5 -3 lines)
MODIFY lib/simpletest/Attic/testdmllib.php   Rev. 1.7    (+3 -3 lines)
Nicolas Connault committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Mar/08 02:13 AM
MDL-14065 Fixed gradebook unit tests, including a bug fix in grade_item class.

Commented out buggy backuplib tests, and replaced E_ALL with DEBUG_DEVELOPER in dmllib tests

Backporting from HEAD
MODIFY lib/grade/simpletest/testgradegrades.php   Rev. 1.4.2.2    (+6 -3 lines)
MODIFY lib/grade/simpletest/testgradeitem.php   Rev. 1.6.2.3    (+14 -22 lines)
MODIFY lib/grade/grade_item.php   Rev. 1.130.2.26    (+2 -2 lines)
MODIFY lib/simpletest/testbackuplib.php   Rev. 1.1.2.4    (+5 -3 lines)
MODIFY lib/simpletest/Attic/testdmllib.php   Rev. 1.6.2.1    (+3 -3 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 28/Mar/08 02:17 AM
There were a few issues in gradebook tests, and the backuplib unit test suite was completely messed up and will have to be refactored using better methods. WIth these changes, all unit tests pass (541 tests in total).

Nicolas Connault made changes - 28/Mar/08 02:17 AM
Fix Version/s 2.0 [ 10122 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Eloy Lafuente (stronk7) made changes - 28/Mar/08 08:54 AM
Link This issue is duplicated by MDL-14081 [ MDL-14081 ]
Martin Dougiamas made changes - 01/Apr/08 11:30 AM
QA Assignee dougiamas
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 01/Apr/08 01:40 PM
Looking fine now, thanks!

Martin Dougiamas made changes - 01/Apr/08 01:40 PM
Status Resolved [ 5 ] Closed [ 6 ]
Martin Dougiamas made changes - 21/Apr/08 09:54 PM
Link This issue is duplicated by MDL-14414 [ MDL-14414 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators