Moodle

Multiple errors in unit tests

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1, 2.0
  • Component/s: Administration
  • Labels:
    None
  • Environment:
    windows 2000, apache 2.2.8, Postgresql 8.3.1, php 5.2.5, Moodle 1.9
  • Database:
    PostgreSQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Unit test reports many errors.

I am unclear if this indicates issues with the related Moodle code or with the tests themselves, so I don't know if this is really a Major issue or a Minor one.

I have attached the resulting error display.

  1. UnitTestErrors.rtf
    27/Mar/08 11:28 PM
    405 kB
    Johnathan Kemp
  2. UnitTestErrors31stMarch08.rtf
    31/Mar/08 6:47 PM
    398 kB
    Johnathan Kemp

Issue Links

Activity

Hide
Ryan Smith added a comment -

I believe this was just fixed with http://tracker.moodle.org/browse/MDL-14065

I just updated my 1.9 to the latest CVS and I get:

20/20 test cases complete: 541 passes, 0 fails and 0 exceptions.

Show
Ryan Smith added a comment - I believe this was just fixed with http://tracker.moodle.org/browse/MDL-14065 I just updated my 1.9 to the latest CVS and I get: 20/20 test cases complete: 541 passes, 0 fails and 0 exceptions.
Hide
Eloy Lafuente (stronk7) added a comment -

Thanks for feedback, Ryan. Closing as dupe of MDL-14065.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Thanks for feedback, Ryan. Closing as dupe of MDL-14065. Ciao
Hide
Johnathan Kemp added a comment - - edited

I have upgraded my Moodle installation today using CVS and my Moodle build is showing as 1.9+ (Build 20080331)

I have subsequently re-run the unit tests and again obtained almost identical error listings which I have attached .

I don't know if this posting is a duplicate of another one relating to unit test errors, however as far as I can see this issue is still unresolved as of 31st March 2008 at 11:00 GMT

Kind regards

Johnathan

Show
Johnathan Kemp added a comment - - edited I have upgraded my Moodle installation today using CVS and my Moodle build is showing as 1.9+ (Build 20080331) I have subsequently re-run the unit tests and again obtained almost identical error listings which I have attached . I don't know if this posting is a duplicate of another one relating to unit test errors, however as far as I can see this issue is still unresolved as of 31st March 2008 at 11:00 GMT Kind regards Johnathan
Hide
Eloy Lafuente (stronk7) added a comment -

Reopening this... thanks for complete feedback Johnathan! B-)

from the output you've sent... it seems that the fullname column isn't specified in the insert statement and it's defined as not null (in fact it's also mandatory in the web interface).

So I guess the test is missing that column... or something like that.

Assigning to Nicolas and addressing for 1.9.1... TIA! Ciao

Show
Eloy Lafuente (stronk7) added a comment - Reopening this... thanks for complete feedback Johnathan! B-) from the output you've sent... it seems that the fullname column isn't specified in the insert statement and it's defined as not null (in fact it's also mandatory in the web interface). So I guess the test is missing that column... or something like that. Assigning to Nicolas and addressing for 1.9.1... TIA! Ciao
Hide
Nicolas Connault added a comment -

Adding the fullname value to test grade_outcomes. All tests should pass now.

Show
Nicolas Connault added a comment - Adding the fullname value to test grade_outcomes. All tests should pass now.
Hide
Johnathan Kemp added a comment -

I upgraded from CVS this morning (April 2nd 08) at about 11:00 am GMT and then re ran the unit tests which completed with one reported test failed, so I can confirm that the above issue is fixed. I'll now check out the issue tracker to see if the fail I am getting is known or not.

Thanks for all your help

Johnathan

Show
Johnathan Kemp added a comment - I upgraded from CVS this morning (April 2nd 08) at about 11:00 am GMT and then re ran the unit tests which completed with one reported test failed, so I can confirm that the above issue is fixed. I'll now check out the issue tracker to see if the fail I am getting is known or not. Thanks for all your help Johnathan
Hide
Eloy Lafuente (stronk7) added a comment -

Reviewed and tested. Closing. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Reviewed and tested. Closing. Thanks!

People

Dates

  • Created:
    Updated:
    Resolved: