[#MDL-14081] Multiple errors in unit tests

Issue Details (XML | Word | Printable)

Key:	MDL-14081
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Major
Assignee:	Nicolas Connault
Reporter:	Johnathan Kemp
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Multiple errors in unit tests

Created: 27/Mar/08 11:28 PM Updated: 03/Apr/08 12:55 AM

Return to search

Component/s:

Administration

Affects Version/s:

1.9

Fix Version/s:

1.9.1, 2.0

File Attachments:

UnitTestErrors.rtf (405 kB)
2.

UnitTestErrors31stMarch08.rtf (398 kB)

Environment:

windows 2000, apache 2.2.8, Postgresql 8.3.1, php 5.2.5, Moodle 1.9

Issue Links:

Duplicate

This issue duplicates:

~~MDL-14065~~ Unit tests showing many failures of all kinds

Database:	PostgreSQL
Participants:	Eloy Lafuente (stronk7), Johnathan Kemp, Nicolas Connault and Ryan Smith
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	02/Apr/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Unit test reports many errors.

I am unclear if this indicates issues with the related Moodle code or with the tests themselves, so I don't know if this is really a Major issue or a Minor one.

I have attached the resulting error display.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Ryan Smith added a comment - 28/Mar/08 03:58 AM

I believe this was just fixed with http://tracker.moodle.org/browse/MDL-14065

I just updated my 1.9 to the latest CVS and I get:

20/20 test cases complete: 541 passes, 0 fails and 0 exceptions.

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 28/Mar/08 08:54 AM

Thanks for feedback, Ryan. Closing as dupe of ~~MDL-14065~~.

Ciao

[ Permalink | « Hide ]

Johnathan Kemp added a comment - 31/Mar/08 06:47 PM - edited

I have upgraded my Moodle installation today using CVS and my Moodle build is showing as 1.9+ (Build 20080331)

I have subsequently re-run the unit tests and again obtained almost identical error listings which I have attached .

I don't know if this posting is a duplicate of another one relating to unit test errors, however as far as I can see this issue is still unresolved as of 31st March 2008 at 11:00 GMT

Kind regards

Johnathan

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 01/Apr/08 05:48 AM

Reopening this... thanks for complete feedback Johnathan! B-)

from the output you've sent... it seems that the fullname column isn't specified in the insert statement and it's defined as not null (in fact it's also mandatory in the web interface).

So I guess the test is missing that column... or something like that.

Assigning to Nicolas and addressing for 1.9.1... TIA! Ciao

[ Permalink | « Hide ]

Nicolas Connault added a comment - 02/Apr/08 02:40 PM

Adding the fullname value to test grade_outcomes. All tests should pass now.

[ Permalink | « Hide ]

Johnathan Kemp added a comment - 02/Apr/08 06:37 PM

I upgraded from CVS this morning (April 2nd 08) at about 11:00 am GMT and then re ran the unit tests which completed with one reported test failed, so I can confirm that the above issue is fixed. I'll now check out the issue tracker to see if the fail I am getting is known or not.

Thanks for all your help

Johnathan

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 03/Apr/08 12:55 AM

Reviewed and tested. Closing. Thanks!

All content on this web site is made available under the GNU General Public License, unless otherwise stated.