Moodle

sending a patch for review/testing

8., 14. are not fixed yet in patch and there might be some fixes not mentioned above

Have tried to review code. Looks good.

Found one minor thing in forum_get_tracking_link() you are using the wrong strings for linktext, I think it should be:

if (forum_tp_is_tracked($forum)) { $linktitle = $strnotrackforum; $linktext = $strnotrackforum; } else { $linktitle = $strtrackforum; $linktext = $strtrackforum; }

Hmm, found an issue with front page site news.

Before patch: Most recent site news post displayed
After patch: All site news posts displayed

Could you be please more specific about the frontpage problem? What should I look for exactly?

Sorry, in the front page settings:

Front page items when logged in is set to 'News items' (as the only option)
News items to show is set to 1

Now on the front page 1 news item is displayed. When I switch to the new patch, all the news items are displayed.

thanks, testing new patch

the new count on course page should be fixed now

Dan, the following code was not cahnged by the patch, not sure what is correct:
if (forum_tp_is_tracked($forum)) { $linktitle = $strnotrackforum; $linktext = $strnotrackforum; } else { $linktitle = $strtrackforum; $linktext = $strtrackforum; }

I just updated from CVS on MOODLE_19_STABLE on my test site and now I can't get to any forums. After updating I visited moodle/admin and it did prompt to update the forum activity. When I try to visit a forum page, such as:

../moodle/mod/forum/index.php?id=920

I get a white screen, no output. The following errors are in my Apache error.log:

[Mon Apr 14 00:58:18 2008] [error] [client 137.112.60.250] PHP Catchable fatal error: Object of class object could not be converted to string in C:\\Apache2\\htdocs\\moodle\\lib
dmllib.php on line 2160, referer: /moodle/course/view.php?id=920

[Mon Apr 14 00:58:20 2008] [error] [client 137.112.60.250] PHP Warning: Illegal offset type in isset or empty in C:\\Apache2\\htdocs\\moodle\\lib
accesslib.php on line 2561, referer: /moodle/course/view.php?id=920

[Mon Apr 14 00:58:20 2008] [error] [client 137.112.60.250] PHP Catchable fatal error: Object of class object could not be converted to string in C:\\Apache2\\htdocs\\moodle\\lib
dmllib.php on line 2160, referer: /moodle/course/view.php?id=920

Hi Ryan,

thanks for the report! Could you please apply the patch, it should show the backtrace of the problem, I can not reproduce it myself.

sending patched file too...

BTW Ryan, do you have any PHP accelerator installed?

Ryan, the regression is fixed, please test latest cvs

Attaching screenshot of the forum tracking screen which I hope explains the issue lang strings problem further

The tooltip has the correct text, the link text is incorrect.

That is of course of the forum list of posts screen.

the like text shows current status and the tool tip says what will happen if you click - I did not invent this, we will have to ask MD

I am using eAccelerator.

I just did a CVS update and got the following new files
mod/forum/lib.php
mod/forum/search.php
mod/forum/view.php

I can now access the forums again.

Thanks for fixing it quickly!

Offtopic comment:

Agreeing 100% about this sort of META bugs (with nice atomic subtasks grouped nicely), it's really a pain to check/understand/verify/close any of those subtasks if all them are committed together.

So I would suggest to perform also atomic commits, each one fixing one subtask (or at least, the minimum number of subtask possible if strongly connected).

That way everything will be easier (but for the developer, I know).

Just one personal proposal... to have everything really atomized and understandable. Ciao

Sorry Eloy, I prefer atomic commits too, this one went through several rounds of refactoring and I worked on this for 3 weeks

Think i've found a regression in forum_user_outline()

forum_count_user_posts() is returning an array of objects:

Array
(
[0] => stdClass Object
(
[lastpost] =>
[postcount] => 0
)

)

And forum_user_outline() is assuming just an objet is returned. Visible in activity outline report

thanks Dan, should be fixed

closing, thanks everybody